Bug 1925940 - Review Request: python-cwcwidth - Python bindings for wc(s)width
Summary: Review Request: python-cwcwidth - Python bindings for wc(s)width
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1920084 1920140
TreeView+ depends on / blocked
 
Reported: 2021-02-07 14:55 UTC by Terje Røsten
Modified: 2021-03-25 01:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-19 20:16:50 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Terje Røsten 2021-02-07 14:55:06 UTC
spec: https://terjeros.fedorapeople.org/python-cwcwidth/python-cwcwidth.spec
srpm: https://terjeros.fedorapeople.org/python-cwcwidth/python-cwcwidth-0.1.2-1.fc33.src.rpm
user: terjeros
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=61530313
desc: 
Python bindings for wc(s)widthcwcwidth provides Python bindings for
wcwidth and wcswidth functions defined in POSIX.1-2001 and
POSIX.1-2008 based on Cython . These functions compute the printable
length of a unicode character/string on a terminal.

Comment 1 Terje Røsten 2021-03-08 18:06:56 UTC
Update:

 0.1.4
 Fix Python provide for Fedora 32.

spec: https://terjeros.fedorapeople.org/python-cwcwidth/python-cwcwidth.spec
srpm: https://terjeros.fedorapeople.org/python-cwcwidth/python-cwcwidth-0.1.4-1.fc31.src.rpm
user: terjeros
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=63361050
desc: 
Python bindings for wc(s)widthcwcwidth provides Python bindings for
wcwidth and wcswidth functions defined in POSIX.1-2001 and
POSIX.1-2008 based on Cython . These functions compute the printable
length of a unicode character/string on a terminal.

Comment 2 Robert-André Mauchin 🐧 2021-03-09 08:01:54 UTC
 - Expat is MIT:

License:        MIT

 - Source0:        https://files.pythonhosted.org/packages/source/c/cwcwidth/cwcwidth-%{version}.tar.gz

→

Source0:        %{pypi_source cwcwidth}

Package approved, please fix the aforementioned issue before import.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "*No copyright* Expat
     License". 5 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/python-cwcwidth/review-
     python-cwcwidth/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-cwcwidth
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-cwcwidth-0.1.4-1.fc35.x86_64.rpm
          python-cwcwidth-debugsource-0.1.4-1.fc35.x86_64.rpm
          python-cwcwidth-0.1.4-1.fc35.src.rpm
python3-cwcwidth.x86_64: W: spelling-error Summary(en_US) wc -> WC, cw, w
python3-cwcwidth.x86_64: W: spelling-error %description -l en_US wc -> WC, cw, w
python3-cwcwidth.x86_64: W: spelling-error %description -l en_US widthcwcwidth -> bandwidths
python3-cwcwidth.x86_64: W: spelling-error %description -l en_US wcwidth -> width
python3-cwcwidth.x86_64: W: spelling-error %description -l en_US wcswidth -> widths
python3-cwcwidth.x86_64: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code
python3-cwcwidth.x86_64: W: invalid-license Expat
python-cwcwidth-debugsource.x86_64: W: invalid-license Expat
python-cwcwidth.src: W: spelling-error Summary(en_US) wc -> WC, cw, w
python-cwcwidth.src: W: spelling-error %description -l en_US wc -> WC, cw, w
python-cwcwidth.src: W: spelling-error %description -l en_US widthcwcwidth -> bandwidths
python-cwcwidth.src: W: spelling-error %description -l en_US wcwidth -> width
python-cwcwidth.src: W: spelling-error %description -l en_US wcswidth -> widths
python-cwcwidth.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code
python-cwcwidth.src: W: invalid-license Expat
3 packages and 0 specfiles checked; 0 errors, 15 warnings.

Comment 3 Terje Røsten 2021-03-11 17:28:07 UTC
Thanks!

Comment 4 Terje Røsten 2021-03-11 17:31:10 UTC
SCM request:

 https://pagure.io/releng/fedora-scm-requests/issue/32769

Comment 5 Tomas Hrcka 2021-03-11 22:36:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cwcwidth

Comment 6 Fedora Update System 2021-03-15 20:08:06 UTC
FEDORA-2021-c8f0ae26ab has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-c8f0ae26ab

Comment 7 Fedora Update System 2021-03-15 20:08:39 UTC
FEDORA-2021-38649166e5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-38649166e5

Comment 8 Fedora Update System 2021-03-15 20:09:07 UTC
FEDORA-2021-0b9680cc56 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b9680cc56

Comment 9 Fedora Update System 2021-03-16 14:43:28 UTC
FEDORA-2021-0b9680cc56 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0b9680cc56 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b9680cc56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-03-17 01:40:49 UTC
FEDORA-2021-38649166e5 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-38649166e5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-38649166e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-03-17 01:49:22 UTC
FEDORA-2021-c8f0ae26ab has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-c8f0ae26ab \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-c8f0ae26ab

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-03-19 20:16:50 UTC
FEDORA-2021-0b9680cc56 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-03-24 02:39:13 UTC
FEDORA-2021-38649166e5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2021-03-25 01:14:38 UTC
FEDORA-2021-c8f0ae26ab has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.