Bug 1932281

Summary: [Assisted-4.7][UI] Unable to change upgrade channel once upgrades were discovered
Product: OpenShift Container Platform Reporter: Ori Michaeli <omichael>
Component: Management ConsoleAssignee: Robb Hamilton <rhamilto>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.7CC: aos-bugs, jokerman, omichael, rhamilto, spadgett, wking, yapei
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The console used to rely on hard coded channel strings in order to populate the channel modal dropdown. Consequence: As a result, users could see channel values that may not be correct for their current version. Fix: If the ClusterVersionOperator does not supply the correct channels for a given version, the channel modal dropdown changes to a text input field and suggests channels for the user to try and provides help text guidance on why this is so. Result: The console no longer relies on hard coded channel string, thus preventing the scenario described in the bug.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:48:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
when channel is not configured
none
when version not found in configured channel
none
there are available updates in configured channel none

Description Ori Michaeli 2021-02-24 12:42:29 UTC
Description of problem:

Before upgrades were discovered there was an option to change the upgrade channel (stable, fast and candidate).
Once there are available updates, only the current channel is presented.

Version-Release number of selected component (if applicable):
4.7.0-rc.1

How reproducible:
Always

Steps to Reproduce:
1. Install an older OCP version.
2. In the web console, go to Administration -> Cluster Settings.
3. Change upgrade channel until the update status shows "Available updates".
4. Try changing the channel again.

Actual results:
Only channel with upgrades showing.

Expected results:
All channels should be visible.

Additional info:
Work around for this is to change the channel in the clusterversion operator yaml file manually through the "Cluster version configuration".

Comment 2 Robb Hamilton 2021-03-10 14:52:30 UTC
This bug occurs because we hard code fallback values for the channels when the clusterVersion does not have valid status.desired.channels in order to work around an issue with nightly builds (see https://bugzilla.redhat.com/show_bug.cgi?id=1894330).  https://docs.google.com/document/d/114ACi3STAuNEkwTvqr8ksFxXZRctzZR7s6qnPocOfjI/edit#heading=h.ot50gcwa9lox outlines fixes where we remove the hard coded fallbacks and do not display channels any time clusterVersion.status.desired.channels is empty.

Comment 4 Yadan Pei 2021-04-07 03:51:37 UTC
Hi Robb,

It looks like upgrading from web console may be affected with the new changes, in the past we hardcoded three channels `stable/fast/candidate-${current ocp version + 1}` for production cluster upgrades, for example we add `stable/fast/candidate-4.5` upgrade channels on released 4.4 cluster. 
Now with the new changes we have to add them manually, right?  Is this also intended?

Comment 5 Robb Hamilton 2021-04-07 11:31:54 UTC
(In reply to Yadan Pei from comment #4)

> Now with the new changes we have to add them manually, right?  Is this also
> intended?

Yes.  With https://github.com/openshift/console/pull/8392, the hard coded channels have been removed and the user must manually enter a channel.  The modal does provide hints about which channels to try, but we no longer populate a dropdown with hard coded channels to choose from.

Comment 6 Yadan Pei 2021-04-08 01:09:12 UTC
since it break existing features I would like to confirm, thank you for your confirmation. 

now everything is working as intended and I will move it to VERIFIED

Comment 7 Yadan Pei 2021-04-08 01:09:41 UTC
Created attachment 1770090 [details]
when channel is not configured

Comment 8 Yadan Pei 2021-04-08 01:11:36 UTC
Created attachment 1770092 [details]
when version not found in configured channel

Comment 9 Yadan Pei 2021-04-08 01:13:06 UTC
Created attachment 1770093 [details]
there are available updates in configured channel

Comment 10 Yadan Pei 2021-04-08 01:14:10 UTC
when updates were detected in configured channel, user still can manually change to any other channel and the changes take effect

this is verified against 4.8.0-0.nightly-2021-04-05-174735

Comment 13 errata-xmlrpc 2021-07-27 22:48:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438