Bug 193271
Summary: | Review Request: python-dns - DNS toolkit for Python | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-29 04:34:33 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 193281 |
Description
Jeffrey C. Ollie
2006-05-26 18:34:06 UTC
Review for release 1: * RPM name is OK * Source dnspython-1.3.5.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED Minor: * Use of buildroot is not consistant. (wiki: PackagingGuidelines#UsingBuildRootOptFlags) Please change your occurence of %{buildroot} in %check into $RPM_BUILD_ROOT Thanks for the review! Package imported, built for devel, branches requested for FC-4 and FC-5. Package Change Request ====================== Package Name: python-dns New Branches: EL-5 Owners: jcollie Package Change Request ====================== Package Name: python-dns New Branches: EL-5 Owners: jcollie,pwouters cvs done. |