Red Hat Bugzilla – Bug 193271
Review Request: python-dns - DNS toolkit for Python
Last modified: 2008-11-18 22:51:31 EST
Spec URL: http://www.ocjtech.us/python-dns-1.3.5-1.spec SRPM URL: http://www.ocjtech.us/python-dns-1.3.5-1.src.rpm Description: dnspython is a DNS toolkit for Python. It supports almost all record types. It can be used for queries, zone transfers, and dynamic updates. It supports TSIG authenticated messages and EDNS0. dnspython provides both high and low level access to DNS. The high level classes perform queries for data of a given name, type, and class, and return an answer set. The low level classes allow direct manipulation of DNS zones, messages, names, and records.
Review for release 1: * RPM name is OK * Source dnspython-1.3.5.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED Minor: * Use of buildroot is not consistant. (wiki: PackagingGuidelines#UsingBuildRootOptFlags) Please change your occurence of %{buildroot} in %check into $RPM_BUILD_ROOT
Thanks for the review! Package imported, built for devel, branches requested for FC-4 and FC-5.
Package Change Request ====================== Package Name: python-dns New Branches: EL-5 Owners: jcollie
Package Change Request ====================== Package Name: python-dns New Branches: EL-5 Owners: jcollie,pwouters
cvs done.