Bug 1934402

Summary:	Review Request: rust-case - Set of letter case string helpers
Product:	[Fedora] Fedora	Reporter:	Sohan Kunkerkar <skunkerk>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bgilbert, decathorpe, extras-qa, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1931427
Clones:	1939404 (view as bug list)		Environment:
Last Closed:	2021-10-31 12:54:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sohan Kunkerkar 2021-03-03 07:26:14 UTC

Spec URL: https://sohank2602.fedorapeople.org/rust-case/rust-case.spec
SRPM URL: https://sohank2602.fedorapeople.org/rust-case-1.0.0-1.fc33.src.rpm
Description: Set of letter case string helpers
Fedora Account System Username: sohank2602

I have verified this build by using the `--postinstall` option.
Also, using `%undefine __brp_mangle_shebangs` to suppress a few shebangs warnings.

Comment 1 Fabio Valentini 2021-03-03 12:27:11 UTC

Do not just drop __brp_mangle_shebangs ... It might have unintended side effects.

Instead, fix the actual problem (e.g. removing executable bit from files that are not supposed to be executables at the end of %prep), with something like:
"chmod -x README.md src/lib.rs" (substitute for whatever the affected files are).

Comment 2 Sohan Kunkerkar 2021-03-03 16:32:16 UTC

(In reply to Fabio Valentini from comment #1)
> Do not just drop __brp_mangle_shebangs ... It might have unintended side
> effects.
> 
> Instead, fix the actual problem (e.g. removing executable bit from files
> that are not supposed to be executables at the end of %prep), with something
> like:
> "chmod -x README.md src/lib.rs" (substitute for whatever the affected files
> are).

Thanks for the review. Fixed this in the latest push.

Comment 3 Fabio Valentini 2021-03-03 17:08:41 UTC

It would be great if you added a comment above the chmod line (why is this necessary? those files should not have the executable bit set, and it breaks things). Upstream project seems to be dead, so I'm not sure if it's going to help if you open a pull request there to fix the permissions in the git repository.

Other than that:

Package generated with rust2rpm, simplifying the review.

- package conforms to Rust Packaging Guidelines
- package builds and installs successfully on rawhide
- latest version is packaged
- license matches upstream and license file is installed with %license
- tests are run (but there are no tests in the project :sad-face:)

Package APPROVED.

Please add the comment about why the "chmod -x" step is necessary to the .spec file before committing it into dist-git.

Comment 4 Sohan Kunkerkar 2021-03-04 02:15:21 UTC

> Please add the comment about why the "chmod -x" step is necessary to the
> .spec file before committing it into dist-git.

Sure thing!

Comment 5 Tomas Hrcka 2021-03-04 11:37:53 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-case

Comment 6 Fabio Valentini 2021-10-31 12:54:06 UTC

This package is available for Fedora 35+.