Spec URL: https://sohank2602.fedorapeople.org/rust-case/rust-case.spec SRPM URL: https://sohank2602.fedorapeople.org/rust-case-1.0.0-1.fc33.src.rpm Description: Set of letter case string helpers Fedora Account System Username: sohank2602 I have verified this build by using the `--postinstall` option. Also, using `%undefine __brp_mangle_shebangs` to suppress a few shebangs warnings.
Do not just drop __brp_mangle_shebangs ... It might have unintended side effects. Instead, fix the actual problem (e.g. removing executable bit from files that are not supposed to be executables at the end of %prep), with something like: "chmod -x README.md src/lib.rs" (substitute for whatever the affected files are).
(In reply to Fabio Valentini from comment #1) > Do not just drop __brp_mangle_shebangs ... It might have unintended side > effects. > > Instead, fix the actual problem (e.g. removing executable bit from files > that are not supposed to be executables at the end of %prep), with something > like: > "chmod -x README.md src/lib.rs" (substitute for whatever the affected files > are). Thanks for the review. Fixed this in the latest push.
It would be great if you added a comment above the chmod line (why is this necessary? those files should not have the executable bit set, and it breaks things). Upstream project seems to be dead, so I'm not sure if it's going to help if you open a pull request there to fix the permissions in the git repository. Other than that: Package generated with rust2rpm, simplifying the review. - package conforms to Rust Packaging Guidelines - package builds and installs successfully on rawhide - latest version is packaged - license matches upstream and license file is installed with %license - tests are run (but there are no tests in the project :sad-face:) Package APPROVED. Please add the comment about why the "chmod -x" step is necessary to the .spec file before committing it into dist-git.
> Please add the comment about why the "chmod -x" step is necessary to the > .spec file before committing it into dist-git. Sure thing!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-case
This package is available for Fedora 35+.