Bug 1935219
| Summary: | [CNV-2.5] Set memory and CPU request on hco-operator and hco-webhook deployments | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | sgott |
| Component: | Installation | Assignee: | Simone Tiraboschi <stirabos> |
| Status: | CLOSED ERRATA | QA Contact: | Debarati Basu-Nag <dbasunag> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 2.5.3 | CC: | cnv-qe-bugs, dbasunag, ipinto, jgil, kbidarka, stirabos |
| Target Milestone: | --- | ||
| Target Release: | 4.9.0 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | hco-bundle-registry-container-v4.9.0-32 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1931519 | Environment: | |
| Last Closed: | 2021-11-02 15:57:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1931519 | ||
| Bug Blocks: | 1935217, 1935218 | ||
|
Description
sgott
2021-03-04 14:45:53 UTC
This is a subset of a larger effort ( https://bugzilla.redhat.com/1931519 ); in this specific bug we are focusing only at setting memory and CPU limits on hco-operator and hco-webhook deployments. While working on this, we found out that HCO is watching ConfigMaps (and Services) across the whole cluster, leading to unpredictable memory consumption depending on the size of the cluster. To rectify this we are looking into filtering our caches for those objects. Will update this issue as soon as we agreed on how to tackle it. We are now waiting this change on controller-runtime: https://github.com/kubernetes-sigs/controller-runtime/pull/1435 to have a predictable memory consumption. Only at that time we will be able to really implement a memory limit. This is probably not going to happen in 4.8 timeframe. https://github.com/kubernetes-sigs/controller-runtime/pull/1435 got merged, we can start consuming it as soon as we will get a new release of controller-runtime According to https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits guidelines that states: " Therefore, cluster components SHOULD NOT be configured with resource limits. However, cluster components MUST declare resource requests for both CPU and memory. " we are going to set resource requests for both CPU and memory but not resource limits. Validated against at 4.9 cluster:
For hco-operator:
=================
resources:
requests:
cpu: 10m
memory: 96Mi
=================
For hco-webhook:
=================
resources:
requests:
cpu: 5m
memory: 48Mi
=================
Based on this above results, marking this ticket as verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Virtualization 4.9.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:4104 |