+++ This bug was initially created as a clone of Bug #1931519 +++ This is a clone to track items specifically related to network component ------------ Description of problem: Most of the deployments and daemonsets stored in the openshift-cnv namespace don't specify the resource request in their manifests. Only daemonset/kube-cni-linux-bridge-plugin, deployment/kubemacpool-mac-controller-manager and daemonset/kube-cni-linux-bridge-plugin have it defined as follows: Kind | Name | CPU Req/Limits | Mem Req/Limits ---------- | ---------------------------------- | -------------- | --------------- daemonset | kube-cni-linux-bridge-plugin | 60m/0m | 30Mi/0Mi deployment | kubemacpool-mac-controller-manager | 100m/300m | 300Mi/600Mi The following list of manifests don't define the resource requirements: Kind | Name ---------- | ---- daemonset | bridge-marker daemonset | nmstate-handler daemonset | ovs-cni-amd64 daemonset | bridge-marker daemonset | nmstate-handler daemonset | ovs-cni-amd64 daemonset | kubevirt-node-labeller daemonset | ovs-cni-amd64 daemonset | nmstate-handler deployment | cdi-uploadproxy deployment | cdi-apiserver deployment | nmstate-webhook deployment | hostpath-provisioner-operator deployment | virt-api deployment | virt-controller deployment | virt-handler deployment | virt-operator deployment | virt-template-validator deployment | vm-import-controller deployment | vm-import-operator deployment | cdi-deployment deployment | cluster-network-addons-operator deployment | cdi-operator deployment | cluster-network-addons-operator deployment | kubevirt-ssp-operato deployment | hco-operator Version-Release number of selected component (if applicable): CNV 2.5.3 and onward. How reproducible: Steps to Reproduce: 1.Create CNV namespace 2.Create CNV Operator Group 3.Create HCO subscription and deploy stable 4.Wait for deployment of HCO operator to complete 5.Check for resource requests in deployed manifests. Actual results: Only 2 deployed manifests define their resource requirements, and only 1 define the resource limits (see list above). Expected results: All deployed manifests define the resource requirements. Additional info: N/A
OpenShift guidelines on this matter: https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits
Following manifests do not contain resource requirements: deployment | cdi-uploadproxy deployment | cdi-apiserver deployment | hostpath-provisioner-operator deployment | virt-handler deployment | virt-operator deployment | vm-import-controller deployment | vm-import-operator deployment | cdi-deployment deployment | cdi-operator deployment | kubevirt-ssp-operato deployment | hco-operator Same reproduction steps as bug report. Verified on cnv-v4.8.1-2 OC version - Client Version: 4.8.0-202108120034.p0.git.0d10c3f.assembly.stream-0d10c3f Server Version: 4.8.4 Kubernetes Version: v1.21.1+38b3ecc
This epic is targeted at network components (there are other counterparts for storage and compute). None of the components you listed above is owned by network. Could we move it back on QE?
My bad. In that case, I guess it's verified. Can I move it directly to verified, or does it need to go through ->ON_QE->VERIFIED path?
Verified. All deployed network components' manifests include resource requests. Same reproduction steps as bug report. Verified on cnv-v4.8.1-2 OC version - Client Version: 4.8.0-202108120034.p0.git.0d10c3f.assembly.stream-0d10c3f Server Version: 4.8.4 Kubernetes Version: v1.21.1+38b3ecc
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Virtualization 4.8.1 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:3259