Bug 1938465

Summary:	thanos-querier should set a CPU request on the thanos-query container
Product:	OpenShift Container Platform	Reporter:	Clayton Coleman <ccoleman>
Component:	Monitoring	Assignee:	Simon Pasquier <spasquie>
Status:	CLOSED ERRATA	QA Contact:	hongyan li <hongyli>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.8	CC:	alegrand, anpicker, erooth, hongyli, kakkoyun, lcosic, pkrupa, spasquie
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:53:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Clayton Coleman 2021-03-13 17:34:38 UTC

All payload components should request a reasonable minimum CPU

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits

thanos-query container in thanos-querier does not.  I recommend assessing the p90 CPU use during an e2e run and using that value (something between 10m and 50m sounds "roughly correct").

Referenced from the new e2e test which gates components without resource requests and enforces the resource conventions.

Comment 2 hongyan li 2021-04-16 02:10:20 UTC

Test with payload 4.8.0-0.nightly-2021-04-15-152737

CPU request for container thanos-query is increased to 10m

oc -n openshift-monitoring get deployment.apps/thanos-querier -o go-template='{{range.spec.template.spec.containers}}{{"Container Name: "}}{{.name}}{{"\r\nresources: "}}{{.resources}}{{"\n"}}{{end}}'; echo -e "\n";
Container Name: thanos-query
resources: map[requests:map[cpu:10m memory:12Mi]]

Comment 5 errata-xmlrpc 2021-07-27 22:53:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438