Bug 1938465 - thanos-querier should set a CPU request on the thanos-query container
Summary: thanos-querier should set a CPU request on the thanos-query container
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Monitoring
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.8.0
Assignee: Simon Pasquier
QA Contact: hongyan li
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-13 17:34 UTC by Clayton Coleman
Modified: 2021-07-27 22:53 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:53:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-monitoring-operator pull 1106 0 None open Bug 1938465: increase CPU requests for Thanos querier 2021-04-06 14:05:19 UTC
Github openshift origin pull 26048 0 None open [WIP] Bug 1938465: test/extended/operators: remove CPU limits exception for Thanos querier 2021-04-06 13:52:40 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:53:36 UTC

Description Clayton Coleman 2021-03-13 17:34:38 UTC
All payload components should request a reasonable minimum CPU

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits

thanos-query container in thanos-querier does not.  I recommend assessing the p90 CPU use during an e2e run and using that value (something between 10m and 50m sounds "roughly correct").

Referenced from the new e2e test which gates components without resource requests and enforces the resource conventions.

Comment 2 hongyan li 2021-04-16 02:10:20 UTC
Test with payload 4.8.0-0.nightly-2021-04-15-152737

CPU request for container thanos-query is increased to 10m

oc -n openshift-monitoring get deployment.apps/thanos-querier -o go-template='{{range.spec.template.spec.containers}}{{"Container Name: "}}{{.name}}{{"\r\nresources: "}}{{.resources}}{{"\n"}}{{end}}'; echo -e "\n";
Container Name: thanos-query
resources: map[requests:map[cpu:10m memory:12Mi]]

Comment 5 errata-xmlrpc 2021-07-27 22:53:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.