Bug 1938568

Summary:	[RHOSP16.2][STF] Overcloud deployment fails when adding PluginInstanceFormat in collectd ExtraConfig
Product:	Red Hat OpenStack	Reporter:	Leonid Natapov <lnatapov>
Component:	puppet-collectd	Assignee:	Leif Madsen <lmadsen>
Status:	CLOSED ERRATA	QA Contact:	Leonid Natapov <lnatapov>
Severity:	high	Docs Contact:
Priority:	high
Version:	16.1 (Train)	CC:	jbadiapa, jjoyce, jschluet, lars, mmagr, mrunge, rmccabe, slinaber, tvignaud
Target Milestone:	ga	Keywords:	Triaged, ZStream
Target Release:	16.2 (Train on RHEL 8.4)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	puppet-collectd-12.0.1-2.20210428165301.4686e16.el8ost	Doc Type:	Enhancement
Doc Text:	Before this update, the `PluginInstanceFormat` parameter for `collectd` could specify only one of the following values: 'none', 'name', 'uuid', or 'metadata'. After this update, the `PluginInstanceFormat` parameter for `collectd` can now specify more than one value, which results in more information being sent in the `plugin_instance` label of `collectd` metrics.	Story Points:	---
Clone Of:
Clones:	1954103 1956887 (view as bug list)		Environment:
Last Closed:	2021-09-15 07:12:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1954103, 1956887

Description Leonid Natapov 2021-03-14 16:01:39 UTC

STF | Overcloud deployment fails when adding PluginInstanceFormat in collectd ExtraConfig

When STF deployment yaml file e.g.  stf-connectors.yaml includes

ExtraConfig:
   collectd::plugin::virt::plugin_instance_format: name uuid metadata

the overcloud deployment fails.

The deployment passes if collectd::plugin::virt::plugin_instance_format has only one parameter e.g.

ExtraConfig:
   collectd::plugin::virt::plugin_instance_format: name 

The error message that received in the case when deployment fails is following:

Error: Error while evaluating a Function Call, Class[Collectd::Plugin::Virt]: parameter 'plugin_instance_format' expects an undef value or a match for Enum['metadata', 'name', 'none', 'uuid'], got 'name metadata uuid' (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/collectd_plugin.pp, line: 5, column: 3) (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd/collectd_service.pp, line: 8) on node compute-0.redhat.local

Comment 5 Leif Madsen 2021-04-21 16:36:32 UTC

Upstream CI passes. Just waiting for review and merge.

Comment 6 Leif Madsen 2021-04-26 21:06:50 UTC

Changes are now merged upstream

Comment 11 Leonid Natapov 2021-06-15 13:45:17 UTC

overcloud deployment was successful with collectd::plugin::virt::plugin_instance_format: name uuid metadata

Comment 14 errata-xmlrpc 2021-09-15 07:12:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform (RHOSP) 16.2 enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:3483