Bug 1939018

Summary:	clang-format-diff is not in a PATH
Product:	[Fedora] Fedora	Reporter:	Ray Kinsella <mdr>
Component:	clang	Assignee:	Tom Stellard <tstellar>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	33	CC:	airlied, mdr, robinlee.sysu, sbergman, sguelton, siddharth.kde, tstellar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-02 03:23:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ray Kinsella 2021-03-15 13:12:08 UTC

Description of problem:

clang-format-diff.py is not being installed to a PATH, it is being placed in the /usr/share/clang directory. This means that heroics are required to find and execute it on Fedora, which are not required on other OSs. 

Please see this Gerrit for an example of the required heroics. 

https://gerrit.fd.io/r/c/vpp/+/31633

Version-Release number of selected component (if applicable):

Clang 10 / Fedora 32 & 33

How reproducible:

[root@xyz vpp]# clang-format-diff
-bash: clang-format-diff: command not found
[root@xyz vpp]# ls -l /usr/share/clang/clang-format-diff.py
-rwxr-xr-x. 1 root root 4588 Jul  7  2020 /usr/share/clang/clang-format-diff.py

Comment 1 Tom Stellard 2021-04-14 02:53:28 UTC

Proposed fix: https://src.fedoraproject.org/rpms/clang/pull-request/104

Comment 2 Fedora Update System 2021-05-14 12:50:35 UTC

FEDORA-2021-6ee48cc231 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ee48cc231

Comment 3 Fedora Update System 2021-05-14 18:35:07 UTC

FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6ee48cc231`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6ee48cc231

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2021-05-22 01:07:49 UTC

FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Tom Stellard 2021-10-02 03:23:56 UTC

(In reply to Fedora Update System from comment #4)
> FEDORA-2021-6ee48cc231 has been pushed to the Fedora 33 stable repository.
> If problem still persists, please make note of it in this bug report.

This means it has been fixed.