Bug 1944415

Summary:	Buttons and tooltips are confusing in the Create Mapping page
Product:	Migration Toolkit for Virtualization	Reporter:	Nandini Chandra <nachandr>
Component:	User Experience	Assignee:	Mike Turley <mturley>
Status:	CLOSED ERRATA	QA Contact:	Igor Braginsky <ibragins>
Severity:	low	Docs Contact:	Avital Pinnick <apinnick>
Priority:	low
Version:	2.0.0	CC:	fdupont, vconzola
Target Milestone:	---	Keywords:	UsabilityStudyPriority
Target Release:	2.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-10 17:11:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nandini Chandra 2021-03-29 21:43:46 UTC

Description of problem:
-----------------------
Some users in the usability study were unsure of the purpose of the Add button on the create mapping form, which inserts another source/target pair in the mapping editor. Some of the confusion was because of the fact that you have active "Add and "Create" buttons on the same page, which both sound like the primary verb on the page.


Version-Release number of selected component (if applicable):
-------------------------------------------------------------


How reproducible:
----------------


Steps to Reproduce:
------------------
1.
2.
3.


Actual results:
---------------


Expected results:
----------------


Additional info:
----------------

Comment 1 Fabien Dupont 2021-04-01 12:27:41 UTC

@vconzola what do you think? Should we make the "Add" button more explicit ? "Add mapping" ?

Comment 2 vconzola 2021-04-01 18:21:32 UTC

@fdupont I think the confusion arose from the fact that the Add button is present all of the time, but is often disabled depending on the state of the mapping. Mike and I discussed this at length and will make the following changes: (1) hide the button (rather than disable) unless Add is a valid action at the time, (2) only disable the button (with a tooltip) when all source networks/datastores have been mapped, and (3) Add button will never appear as a primary button. Issue is being tracked here: https://github.com/konveyor/forklift-ui/issues/488.

Comment 3 Fabien Dupont 2021-04-01 18:25:31 UTC

Sounds good.

Comment 4 vconzola 2021-04-01 18:28:36 UTC

I just verified that Add is always displayed as a secondary action button (never primary) as specified by the PatternFly guidelines, so my (3) above is a no op.

Comment 5 Fabien Dupont 2021-04-08 11:49:09 UTC

This fix should be part of build v2.0.0-14, iib:64369.

Comment 6 Igor Braginsky 2021-05-11 09:17:28 UTC

Looks good to me, checked on 2.0.0-13

Comment 9 errata-xmlrpc 2021-06-10 17:11:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381