Description of problem: ----------------------- Some users in the usability study were unsure of the purpose of the Add button on the create mapping form, which inserts another source/target pair in the mapping editor. Some of the confusion was because of the fact that you have active "Add and "Create" buttons on the same page, which both sound like the primary verb on the page. Version-Release number of selected component (if applicable): ------------------------------------------------------------- How reproducible: ---------------- Steps to Reproduce: ------------------ 1. 2. 3. Actual results: --------------- Expected results: ---------------- Additional info: ----------------
@vconzola what do you think? Should we make the "Add" button more explicit ? "Add mapping" ?
@fdupont I think the confusion arose from the fact that the Add button is present all of the time, but is often disabled depending on the state of the mapping. Mike and I discussed this at length and will make the following changes: (1) hide the button (rather than disable) unless Add is a valid action at the time, (2) only disable the button (with a tooltip) when all source networks/datastores have been mapped, and (3) Add button will never appear as a primary button. Issue is being tracked here: https://github.com/konveyor/forklift-ui/issues/488.
Sounds good.
I just verified that Add is always displayed as a secondary action button (never primary) as specified by the PatternFly guidelines, so my (3) above is a no op.
This fix should be part of build v2.0.0-14, iib:64369.
Looks good to me, checked on 2.0.0-13
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (MTV 2.0.0 images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:2381