Bug 1944658
| Summary: | Review Request: htppu - Hessu's Tampa Ping-Pong conversd URO modified version | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Zdenek Dohnal <zdohnal> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rlescak, zdohnal |
| Target Milestone: | --- | Flags: | zdohnal:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-04-20 22:58:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jaroslav Škarvada
2021-03-30 12:30:34 UTC
Upstream was notified that the license text is missing. rpmlint found few warnings and error: htppu.x86_64: E: non-readable /etc/htppu/convers.conf 640 htppu.x86_64: W: dangling-relative-symlink /usr/share/doc/htppu/ChangeLog ./doc/ChangeLog htppu.x86_64: W: dangling-relative-symlink /usr/share/doc/htppu/README ./doc/README htppu.x86_64: W: spelling-error Summary(en_US) Hessu's -> Hess's, Hesse's, Hessian's htppu.x86_64: W: spelling-error .... rpmlint error: Rpmlint complains about readability of a file, if there is a specific reason for that (like a security reason), then it is fine I guess. rpmlint warnings: Packages contain both symbolic links and the files so I think that all warnings can be ignored, rest of them were just warnings from spell check. Except that, and mentioned missing license I didn't find anything. All looks fine to me. Giving review+ based on Richard's review. Jarda, do you know about the reason why /etc/htppu/convers.conf is not readable for others? (In reply to Zdenek Dohnal from comment #4) > Jarda, do you know about the reason why /etc/htppu/convers.conf is not > readable for others? It's intended, it holds security number needed for gaining 'operator' status. Thanks for the review. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/htppu FEDORA-2021-bcca754d67 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcca754d67 FEDORA-2021-57b19ae28b has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-57b19ae28b FEDORA-2021-bcca754d67 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bcca754d67 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcca754d67 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-57b19ae28b has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-57b19ae28b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-57b19ae28b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-bcca754d67 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-57b19ae28b has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |