Bug 1944658 - Review Request: htppu - Hessu's Tampa Ping-Pong conversd URO modified version
Summary: Review Request: htppu - Hessu's Tampa Ping-Pong conversd URO modified version
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zdenek Dohnal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-30 12:30 UTC by Jaroslav Škarvada
Modified: 2021-04-29 00:56 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-04-20 22:58:02 UTC
Type: ---
Embargoed:
zdohnal: fedora-review+


Attachments (Terms of Use)

Description Jaroslav Škarvada 2021-03-30 12:30:34 UTC
Spec URL: https://jskarvad.fedorapeople.org/htppu/htppu.spec
SRPM URL: https://jskarvad.fedorapeople.org/htppu/htppu-1.8-1.fc32.src.rpm
Description: The URO modified Ping-Pong conversd, derived from WAMPES' conversd by Dieter Deyke <deyke.hp.com>. It is also used in the Internet for ham radio conversation groups.
Fedora Account System Username: jskarvad

Comment 1 Jaroslav Škarvada 2021-03-30 12:31:03 UTC
Upstream was notified that the license text is missing.

Comment 2 Richard Lescak 2021-04-08 08:26:14 UTC
rpmlint found few warnings and error:

htppu.x86_64: E: non-readable /etc/htppu/convers.conf 640

htppu.x86_64: W: dangling-relative-symlink /usr/share/doc/htppu/ChangeLog ./doc/ChangeLog
htppu.x86_64: W: dangling-relative-symlink /usr/share/doc/htppu/README ./doc/README
htppu.x86_64: W: spelling-error Summary(en_US) Hessu's -> Hess's, Hesse's, Hessian's
htppu.x86_64: W: spelling-error ....


rpmlint error: Rpmlint complains about readability of a file, if there is a specific reason for that (like a security reason), then it is fine I guess.

rpmlint warnings: Packages contain both symbolic links and the files so I think that all warnings can be ignored, rest of them were just warnings from spell check.

Except that, and mentioned missing license I didn't find anything. All looks fine to me.

Comment 3 Zdenek Dohnal 2021-04-13 05:14:59 UTC
Giving review+ based on Richard's review.

Comment 4 Zdenek Dohnal 2021-04-13 05:17:37 UTC
Jarda, do you know about the reason why /etc/htppu/convers.conf is not readable for others?

Comment 5 Jaroslav Škarvada 2021-04-13 17:21:39 UTC
(In reply to Zdenek Dohnal from comment #4)
> Jarda, do you know about the reason why /etc/htppu/convers.conf is not
> readable for others?

It's intended, it holds security number needed for gaining 'operator' status.

Comment 6 Jaroslav Škarvada 2021-04-13 17:22:16 UTC
Thanks for the review.

Comment 7 Gwyn Ciesla 2021-04-20 13:16:48 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/htppu

Comment 8 Fedora Update System 2021-04-20 23:10:45 UTC
FEDORA-2021-bcca754d67 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcca754d67

Comment 9 Fedora Update System 2021-04-20 23:11:18 UTC
FEDORA-2021-57b19ae28b has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-57b19ae28b

Comment 10 Fedora Update System 2021-04-21 15:01:15 UTC
FEDORA-2021-bcca754d67 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bcca754d67 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bcca754d67

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-04-21 22:01:29 UTC
FEDORA-2021-57b19ae28b has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-57b19ae28b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-57b19ae28b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-04-29 00:30:54 UTC
FEDORA-2021-bcca754d67 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-04-29 00:56:31 UTC
FEDORA-2021-57b19ae28b has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.