Bug 1944761

Summary:	field level help instances do not use common util component <FieldLevelHelp>
Product:	OpenShift Container Platform	Reporter:	Robb Hamilton <rhamilto>
Component:	Console Kubevirt Plugin	Assignee:	Phillip Bailey <phbailey>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.8	CC:	aos-bugs, gouyang, phbailey, ycui, yzamir
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:56:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robb Hamilton 2021-03-30 15:42:36 UTC

Description of problem:

* console/frontend/packages/kubevirt-plugin/src/components/vm-disks/guest-agent-file-systems.tsx
* console/frontend/packages/kubevirt-plugin/src/components/vm-disks/vm-disks.tsx

use <Popover> and <QuestionCircleIcon> directly, but should use the common util <FieldLevelHelp> for consistency.  Note <FieldLevelHelp> has been updated to use <OutlinedQuestionCircleIcon>.  See https://github.com/openshift/console/pull/8471

Comment 1 Ying Cui 2021-04-14 07:57:47 UTC

Note: Only way to verify this bug is checking the code, QE will check the regression in general to verify this bug.

Comment 3 Yaacov Zamir 2021-05-02 16:02:34 UTC

grep -R "<Popover" ./frontend/packages/kubevirt-plugin/*

is not empty, Philip are you sure all <popover... are fixed ?

Comment 4 Phillip Bailey 2021-05-04 12:27:13 UTC

Being naive, I didn't check for additional uses. I addressed the two that were listed in the description. I'll create a PR to address the remaining uses.

Comment 5 Guohua Ouyang 2021-05-19 10:14:19 UTC

no obvious side effect found.

Comment 8 errata-xmlrpc 2021-07-27 22:56:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438