Bug 1944761 - field level help instances do not use common util component <FieldLevelHelp>
Summary: field level help instances do not use common util component <FieldLevelHelp>
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.8
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.8.0
Assignee: Phillip Bailey
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-30 15:42 UTC by Robb Hamilton
Modified: 2021-07-27 22:56 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:56:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8793 0 None open Bug 1944761: Use FieldLevelHelp component instead of Popover 2021-04-27 12:08:08 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:56:56 UTC

Description Robb Hamilton 2021-03-30 15:42:36 UTC
Description of problem:

* console/frontend/packages/kubevirt-plugin/src/components/vm-disks/guest-agent-file-systems.tsx
* console/frontend/packages/kubevirt-plugin/src/components/vm-disks/vm-disks.tsx

use <Popover> and <QuestionCircleIcon> directly, but should use the common util <FieldLevelHelp> for consistency.  Note <FieldLevelHelp> has been updated to use <OutlinedQuestionCircleIcon>.  See https://github.com/openshift/console/pull/8471

Comment 1 Ying Cui 2021-04-14 07:57:47 UTC
Note: Only way to verify this bug is checking the code, QE will check the regression in general to verify this bug.

Comment 3 Yaacov Zamir 2021-05-02 16:02:34 UTC
grep -R "<Popover" ./frontend/packages/kubevirt-plugin/*

is not empty, Philip are you sure all <popover... are fixed ?

Comment 4 Phillip Bailey 2021-05-04 12:27:13 UTC
Being naive, I didn't check for additional uses. I addressed the two that were listed in the description. I'll create a PR to address the remaining uses.

Comment 5 Guohua Ouyang 2021-05-19 10:14:19 UTC
no obvious side effect found.

Comment 8 errata-xmlrpc 2021-07-27 22:56:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.