Bug 194551
| Summary: | Review Request: ifd-egate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bob Relyea <rrelyea> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, rstrode |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-17 19:27:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 193187 | ||
| Bug Blocks: | 188268, 195311 | ||
|
Description
Bob Relyea
2006-06-08 22:58:50 UTC
Lost review comments can be read at https://www.redhat.com/archives/fedora-package-review/2006-June/thread.html The latest versions appear to be at: http://directory.fedora.redhat.com/built/rpm_review/rrelyea/ifd-egate.spec http://directory.fedora.redhat.com/built/rpm_review/rrelyea/ifd-egate-0.05-9.src.rpm From quickly skimming the specfile, it looks ok to me. The pcsc_cflags %define at the top is no longer needed though. Comps: here's the big picture: Smart Card Login Packages: Base: pam_pkcs11 (default) coolkey (default) depends on pcsc-lite-libs ifd-egate ccid (default) depends on pcsc-lite ifd-egate (default) depends on pcsc-lite pcsc-lite-libs (default) pcsc-lite (default) Developement Libraries pcsc-lite-devel depends on pcsc-lite-libs coolkey-devel depends on coolkey (In reply to comment #2) > Comps: > > here's the big picture: > Smart Card Login Packages: > > Base: I would put these in Core instead. Base is for the REALLY minimal > pam_pkcs11 (default) > coolkey (default) depends on pcsc-lite-libs ifd-egate > ccid (default) depends on pcsc-lite > ifd-egate (default) depends on pcsc-lite > pcsc-lite-libs (default) > pcsc-lite (default) These would be brought in by the higher level packages, no need to list them. > Developement Libraries > pcsc-lite-devel depends on pcsc-lite-libs > coolkey-devel depends on coolkey > Acceptable. Are all these packages now in Core? Absolutely. I should have typed 'core' rather than Base to begin with... I suspected pcsc-lite would be brought in automatically, which is why I listed the dependencies. Thanks! Bill, with Ville's approval, can we add this to Core? SUre Approving for FC6, added to dist-fc6. Waiting for build into rawhide. Built into rawhide. |