Bug 1945666

9.0 beta was the same as 8.5; so we go this for free;
but 9.0 is now getting rebased, so we now need to chase the machine type to update the machine type to match upstream changes.

*** Bug 2022601 has been marked as a duplicate of this bug. ***

Note historically the RHEL x86 machine types have overridden some of the SMBIOS defaults:

    pcmc->smbios_stream_product = "RHEL-AV";
    pcmc->smbios_stream_version = "8.5.0";

In RHEL-9 there is no separate RHEL-AV product stream any more, so it is likely that we should change SMBIOS to say just 'RHEL' for the 9.x series machine types.

This will likely require an alert to the Windows driver maintainers since they match on some of the SMBIOS data.

See also corresponding question for 8.6 machine types https://bugzilla.redhat.com/show_bug.cgi?id=2031035#c3

Yan: See Dan's comment 8;  if we change the smbios_stream_product on 9.0 to "HREL" rather than -AV, what will break for the windows drivers?
What's your preference?

For now I'll set it as:

+    pcmc->smbios_stream_product = "RHEL-AV";
+    pcmc->smbios_stream_version = "9.0.0";

but please shout if you think we can remove the -AV or if this will cause a problem.

Hi,

On windows update we apply 'HardwareID-6: Manufacturer + SKU Number + Baseboard_Manufacturer + Baseboard_Product' listed here: https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/using-chids
And I don't see any risk for the change, we will get proper HardwareID from the host OS when we submit it, whatever it is.

Regards,
Qianqian

Additionally, current change does not influence virtio-win drivers on Windows Update because RHEL8.6/RHEL9.0 are all NOT released, we don't have existed submission on Windows Update, so we can get proper HardwareID later than your change.

If you have any change on released product: RHEL-AV 8.4/8.5, please let us know. We will need to change the information on Windows Update accordingly.

Thanks,
Qianqian

(In reply to Qianqian Zhu from comment #15)
> Additionally, current change does not influence virtio-win drivers on
> Windows Update because RHEL8.6/RHEL9.0 are all NOT released, we don't have
> existed submission on Windows Update, so we can get proper HardwareID later
> than your change.
> 
> If you have any change on released product: RHEL-AV 8.4/8.5, please let us
> know. We will need to change the information on Windows Update accordingly.

So at the moment I've kept it the same as RHEL-AV;  what's your preference for 9.0 - do you
want 'RHEL' or 'RHEL-AV' ?
What happens to an image that was installed on one version and then used on a newer version?

Dave

> 
> Thanks,
> Qianqian

(In reply to Qianqian Zhu from comment #14)
> Hi,
> 
> On windows update we apply 'HardwareID-6: Manufacturer + SKU Number +
> Baseboard_Manufacturer + Baseboard_Product' listed here:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/using-
> chids
> And I don't see any risk for the change, we will get proper HardwareID from
> the host OS when we submit it, whatever it is.

So IIUC, you're saying that every time we have a RHEL release you register an additional set of matches with windows update. So any previous version HW strings registered will carry on working, and the new version HW strings can be whatever we want them to be.

With that, I'd say we should use just "RHEL" for the rhel9.x.x machine types

(In reply to Dr. David Alan Gilbert from comment #19)
> (In reply to Qianqian Zhu from comment #15)
> > Additionally, current change does not influence virtio-win drivers on
> > Windows Update because RHEL8.6/RHEL9.0 are all NOT released, we don't have
> > existed submission on Windows Update, so we can get proper HardwareID later
> > than your change.
> > 
> > If you have any change on released product: RHEL-AV 8.4/8.5, please let us
> > know. We will need to change the information on Windows Update accordingly.
> 
> So at the moment I've kept it the same as RHEL-AV;  what's your preference
> for 9.0 - do you
> want 'RHEL' or 'RHEL-AV' ?

It could be 'RHEL' from my perspective.

> What happens to an image that was installed on one version and then used on
> a newer version?

We will register all latest RHEL(or AV) releases to Windows Update for new drivers, now we have AV8.4/AV8.5 on Windows Update, and after RHEL8.6/RHEL9.0 released we will add them to Windows Update too.
So if the image running on newer version I assume they will just get new drivers.

> 
> Dave
> 
> > 
> > Thanks,
> > Qianqian

(In reply to Daniel Berrangé from comment #20)
> (In reply to Qianqian Zhu from comment #14)
> > Hi,
> > 
> > On windows update we apply 'HardwareID-6: Manufacturer + SKU Number +
> > Baseboard_Manufacturer + Baseboard_Product' listed here:
> > https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/using-
> > chids
> > And I don't see any risk for the change, we will get proper HardwareID from
> > the host OS when we submit it, whatever it is.
> 
> So IIUC, you're saying that every time we have a RHEL release you register
> an additional set of matches with windows update. So any previous version HW
> strings registered will carry on working, and the new version HW strings can
> be whatever we want them to be.

Correct.

> 
> With that, I'd say we should use just "RHEL" for the rhel9.x.x machine types

Agree.

(In reply to Qianqian Zhu from comment #22)
> (In reply to Daniel Berrangé from comment #20)
> > (In reply to Qianqian Zhu from comment #14)
> > > Hi,
> > > 
> > > On windows update we apply 'HardwareID-6: Manufacturer + SKU Number +
> > > Baseboard_Manufacturer + Baseboard_Product' listed here:
> > > https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/using-
> > > chids
> > > And I don't see any risk for the change, we will get proper HardwareID from
> > > the host OS when we submit it, whatever it is.
> > 
> > So IIUC, you're saying that every time we have a RHEL release you register
> > an additional set of matches with windows update. So any previous version HW
> > strings registered will carry on working, and the new version HW strings can
> > be whatever we want them to be.
> 
> Correct.
> 
> > 
> > With that, I'd say we should use just "RHEL" for the rhel9.x.x machine types
> 
> Agree.

OK, new version coming up.

merge request branch updated; now shows:



Handle 0x0200, DMI type 2, 15 bytes
Base Board Information
        Manufacturer: Red Hat
        Product Name: RHEL
        Version: RHEL-9.0.0 PC (Q35 + ICH9, 2009)
        Serial Number: Not Specified
        Asset Tag: Not Specified
        Features:
                Board is a hosting board

Handle 0x0200, DMI type 2, 15 bytes
Base Board Information
        Manufacturer: Red Hat
        Product Name: RHEL-AV
        Version: RHEL-8.6.0 PC (Q35 + ICH9, 2009)
        Serial Number: Not Specified
        Asset Tag: Not Specified
        Features:
                Board is a hosting board

QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: qemu-kvm), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2307