Bug 1946253
| Summary: | Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-04-06 17:47:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1942239, 1943583 | ||
| Bug Blocks: | 1942238 | ||
|
Description
Peter Robinson
2021-04-05 14:53:05 UTC
- Bump to 0.1.1
- Explain the changes you made in fix metadata
# Initial patched metadata
# * Downgrade log to 0.4.13
Patch0: cryptoki-fix-metadata.diff
- The tests fail:
Running `/builddir/build/BUILD/cryptoki-0.1.0/target/release/deps/basic-f7cee1507995136e`
running 4 tests
test encrypt_decrypt ... FAILED
test import_export ... FAILED
test sign_verify ... FAILED
test login_feast ... FAILED
failures:
---- encrypt_decrypt stdout ----
thread 'encrypt_decrypt' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- import_export stdout ----
thread 'import_export' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
---- sign_verify stdout ----
thread 'sign_verify' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
---- login_feast stdout ----
thread 'login_feast' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
failures:
encrypt_decrypt
import_export
login_feast
sign_verify
test result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
From their CI, this is how to run them:
%generate_buildrequires
%cargo_generate_buildrequires
echo "softhsm"
[…]
%if %{with check}
%check
export PKCS11_SOFTHSM2_MODULE=%{_libdir}/pkcs11/libsofthsm2.so
mkdir /tmp/tokens
echo "directories.tokendir = /tmp/tokens" > /tmp/softhsm2.conf
export SOFTHSM2_CONF=/tmp/softhsm2.conf
%cargo_test
%endif
All fixed: SPEC: https://pbrobinson.fedorapeople.org/rust-cryptoki.spec SRPM: https://pbrobinson.fedorapeople.org/rust-cryptoki-0.1.1-1.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=65252816 Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cryptoki |