Bug 1946253 - Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API
Summary: Review Request: rust-cryptoki - Rust-native wrapper around the PKCS #11 API
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1942239 1943583
Blocks: 1942238
TreeView+ depends on / blocked
 
Reported: 2021-04-05 14:53 UTC by Peter Robinson
Modified: 2021-04-06 17:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-06 17:47:38 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Peter Robinson 2021-04-05 14:53:05 UTC
SPEC: https://pbrobinson.fedorapeople.org/rust-cryptoki.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-cryptoki-0.1.0-1.fc34.src.rpm

Description:
Rust-native wrapper around the PKCS #11 API

FAS: pbrobinson

Comment 1 Robert-André Mauchin 🐧 2021-04-05 18:15:37 UTC
 - Bump to 0.1.1

 - Explain the changes you made in fix metadata

# Initial patched metadata
# * Downgrade log to 0.4.13
Patch0:         cryptoki-fix-metadata.diff

 - The tests fail:

     Running `/builddir/build/BUILD/cryptoki-0.1.0/target/release/deps/basic-f7cee1507995136e`
running 4 tests
test encrypt_decrypt ... FAILED
test import_export ... FAILED
test sign_verify ... FAILED
test login_feast ... FAILED
failures:
---- encrypt_decrypt stdout ----
thread 'encrypt_decrypt' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- import_export stdout ----
thread 'import_export' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
---- sign_verify stdout ----
thread 'sign_verify' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
---- login_feast stdout ----
thread 'login_feast' panicked at 'called `Result::unwrap()` on an `Err` value: LibraryLoading(DlOpen { desc: "/usr/local/lib/softhsm/libsofthsm2.so: cannot open shared object file: No such file or directory" })', tests/common.rs:15:6
failures:
    encrypt_decrypt
    import_export
    login_feast
    sign_verify
test result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


From their CI, this is how to run them:

%generate_buildrequires
%cargo_generate_buildrequires
echo "softhsm"

[…]

%if %{with check}
%check
export PKCS11_SOFTHSM2_MODULE=%{_libdir}/pkcs11/libsofthsm2.so
mkdir /tmp/tokens
echo "directories.tokendir = /tmp/tokens" > /tmp/softhsm2.conf
export SOFTHSM2_CONF=/tmp/softhsm2.conf
%cargo_test
%endif

Comment 3 Robert-André Mauchin 🐧 2021-04-06 14:17:51 UTC
Package approved.

Comment 4 Gwyn Ciesla 2021-04-06 16:02:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cryptoki


Note You need to log in before you can comment on or make changes to this bug.