Bug 1947779

Summary: [LSO] Should allow more nodes to be updated simultaneously for speeding up LSO upgrade
Product: OpenShift Container Platform Reporter: Chao Yang <chaoyang>
Component: StorageAssignee: Christian Huffman <chuffman>
Storage sub component: Local Storage Operator QA Contact: Chao Yang <chaoyang>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: aos-bugs, chuffman
Version: 4.8   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:58:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chao Yang 2021-04-09 08:59:02 UTC 
Description of problem:
Should allow more nodes to be updated simultaneously for speeding up LSO upgrade

Version-Release number of selected component (if applicable):
local-storage-operator.4.8.0-202104072252.p0
4.8.0-0.nightly-2021-04-08-200632

How reproducible:
Always

Steps to Reproduce:
1.Deploy Local Storage Operator
2.Create Localvolume/Localvolumeset/LocalVolumeDiscovery
3.oc get daemonset.apps/diskmaker-manager -o json | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": 1
  },
  "type": "RollingUpdate"
}

oc get daemonset.apps/diskmaker-discovery -ojson | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": 1
  },
  "type": "RollingUpdate"
}


Actual results:
With this update strategy, only one node can be updated at the same time.

Expected results:
For some csi drivers, such as aws ebs csi driver, the update strategy is:
updateStrategy:
  type: RollingUpdate
  rollingUpdate:
    maxUnavailable: 10%

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:
Comment 2 Chao Yang 2021-04-14 14:11:43 UTC 
oc get daemonset.apps/diskmaker-manager -o json | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": "10%"
  },
  "type": "RollingUpdate"
}

oc get daemonset.apps/diskmaker-discovery -ojson | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": "10%"
  },
  "type": "RollingUpdate"
}
local-storage-operator.4.8.0-202104121740.p0
Comment 5 errata-xmlrpc 2021-07-27 22:58:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438