Bug 1947779 - [LSO] Should allow more nodes to be updated simultaneously for speeding up LSO upgrade
Summary: [LSO] Should allow more nodes to be updated simultaneously for speeding up LS...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Storage
Version: 4.8
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.8.0
Assignee: Christian Huffman
QA Contact: Chao Yang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-09 08:59 UTC by Chao Yang
Modified: 2021-07-27 22:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:58:26 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift local-storage-operator pull 227 0 None open Bug 1947779: Include maxUnavailable in DaemonSets 2021-04-09 18:09:04 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:58:46 UTC

Description Chao Yang 2021-04-09 08:59:02 UTC 
Description of problem:
Should allow more nodes to be updated simultaneously for speeding up LSO upgrade

Version-Release number of selected component (if applicable):
local-storage-operator.4.8.0-202104072252.p0
4.8.0-0.nightly-2021-04-08-200632

How reproducible:
Always

Steps to Reproduce:
1.Deploy Local Storage Operator
2.Create Localvolume/Localvolumeset/LocalVolumeDiscovery
3.oc get daemonset.apps/diskmaker-manager -o json | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": 1
  },
  "type": "RollingUpdate"
}

oc get daemonset.apps/diskmaker-discovery -ojson | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": 1
  },
  "type": "RollingUpdate"
}


Actual results:
With this update strategy, only one node can be updated at the same time.

Expected results:
For some csi drivers, such as aws ebs csi driver, the update strategy is:
updateStrategy:
  type: RollingUpdate
  rollingUpdate:
    maxUnavailable: 10%

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:
Comment 2 Chao Yang 2021-04-14 14:11:43 UTC 
oc get daemonset.apps/diskmaker-manager -o json | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": "10%"
  },
  "type": "RollingUpdate"
}

oc get daemonset.apps/diskmaker-discovery -ojson | jq .spec.updateStrategy
{
  "rollingUpdate": {
    "maxSurge": 0,
    "maxUnavailable": "10%"
  },
  "type": "RollingUpdate"
}
local-storage-operator.4.8.0-202104121740.p0
Comment 5 errata-xmlrpc 2021-07-27 22:58:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438
Note You need to log in before you can comment on or make changes to this bug.