Bug 1948149
| Summary: | Review Request: rust-dbus-tokio - Makes it possible to use Tokio with D-Bus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John Baublitz <jbaublitz> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | amulhern, eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-10-25 16:42:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
John Baublitz
2021-04-10 11:36:21 UTC
The successful build is here: https://download.copr.fedorainfracloud.org/results/jbaublitz/rust-dbus-tokio/fedora-rawhide-x86_64/02128261-rust-dbus-tokio/builder-live.log.gz - You must include the license files in the devel subpackage with %license in %files:
%package devel
Summary: %{summary}
BuildArch: noarch
%description devel %{_description}
This package contains library source intended for building other packages
which use "%{crate}" crate.
%files devel
%license LICENSE-APACHE LICENSE-MIT
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package doesn't install properly:
DEBUG util.py:444: - nothing provides (crate(dbus-crossroads/default) >= 0.3.0 with crate(dbus-crossroads/default) < 0.4.0~) needed by rust-dbus-tokio+dbus-crossroads-devel-0.7.3-1.fc35.noarch
Consider sending a pull request to https://src.fedoraproject.org/rpms/rust%2Ddbus%2Dcrossroads to update it.
Package approved. Please fix the aforementioned issue before import.
Here's the link to the updated spec file with the dbus-crossroads feature package removed (this is only used for building examples as far as I can tell from looking at Cargo.toml) and the %license directive added: https://download.copr.fedorainfracloud.org/results/jbaublitz/rust-dbus-tokio/fedora-rawhide-x86_64/02142316-rust-dbus-tokio/rust-dbus-tokio.spec and here is the source RPM which passes rpmlint and can be successfully installed with --postinstall in mock: https://download.copr.fedorainfracloud.org/results/jbaublitz/rust-dbus-tokio/fedora-rawhide-x86_64/02142316-rust-dbus-tokio/rust-dbus-tokio-0.7.3-1.fc35.src.rpm (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dbus-tokio Closing, since review was completed and package is available in 34, 35, 36. Note that we likely won't continue to support it, as stratisd no longer requires it. |