Bug 1948149 - Review Request: rust-dbus-tokio - Makes it possible to use Tokio with D-Bus
Summary: Review Request: rust-dbus-tokio - Makes it possible to use Tokio with D-Bus
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-04-10 11:36 UTC by John Baublitz
Modified: 2021-10-25 16:42 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-10-25 16:42:24 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Comment 2 Robert-André Mauchin 🐧 2021-04-14 14:30:11 UTC
 - You must include the license files in the devel subpackage with %license in %files:

%package        devel
Summary:        %{summary}
BuildArch:      noarch

%description    devel %{_description}

This package contains library source intended for building other packages
which use "%{crate}" crate.

%files          devel
%license LICENSE-APACHE LICENSE-MIT
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines


Package doesn't install properly:

DEBUG util.py:444:    - nothing provides (crate(dbus-crossroads/default) >= 0.3.0 with crate(dbus-crossroads/default) < 0.4.0~) needed by rust-dbus-tokio+dbus-crossroads-devel-0.7.3-1.fc35.noarch

Consider sending a pull request to https://src.fedoraproject.org/rpms/rust%2Ddbus%2Dcrossroads to update it.

Package approved. Please fix the aforementioned issue before import.

Comment 3 John Baublitz 2021-04-20 14:05:37 UTC
Here's the link to the updated spec file with the dbus-crossroads feature package removed (this is only used for building examples as far as I can tell from looking at Cargo.toml) and the %license directive added:

https://download.copr.fedorainfracloud.org/results/jbaublitz/rust-dbus-tokio/fedora-rawhide-x86_64/02142316-rust-dbus-tokio/rust-dbus-tokio.spec

and here is the source RPM which passes rpmlint and can be successfully installed with --postinstall in mock:

https://download.copr.fedorainfracloud.org/results/jbaublitz/rust-dbus-tokio/fedora-rawhide-x86_64/02142316-rust-dbus-tokio/rust-dbus-tokio-0.7.3-1.fc35.src.rpm

Comment 4 Gwyn Ciesla 2021-04-20 14:28:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dbus-tokio

Comment 5 mulhern 2021-10-25 16:42:24 UTC
Closing, since review was completed and package is available in 34, 35, 36. Note that we likely won't continue to support it, as stratisd no longer requires it.


Note You need to log in before you can comment on or make changes to this bug.