Bug 195222
Summary: | Review Request: paman: Management tool for PulseAudio | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pierre Ossman <pierre-bugzilla> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | davidf, green, lpoetter |
Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-09-09 18:03:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 195221 | ||
Bug Blocks: | 163779 |
Description
Pierre Ossman
2006-06-14 15:22:53 UTC
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.2-1.src.rpm MD5Sums: 87dcb41a2c3740eff2e33c094010bb40 paman-0.9.2.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds fine in mock. * rpmlint produces no errors. Bad: * MustFix: Desktop file handling does not conform to FE guidelines. Refer to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.3-1.src.rpm Looks like you missing a BR on desktop-file-utils. Also, is there any reason why your not setting the vendor to fedora? Ah, right, the BR is missing. For the vendor bit, see the discussion in bug 195223. Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.3-2.src.rpm BR added. Ok, this looks good. All blocker issues have been resolved. +1 Approve. Package Change Request ====================== Package Name: paman Updated Fedora Owners: lpoetter,drzeus-bugzilla I am upstream of this package and Pierre agreed to co-maintain this package with me from now on. CVS done. |