Red Hat Bugzilla – Bug 195222
Review Request: paman: Management tool for PulseAudio
Last modified: 2007-11-30 17:11:35 EST
Spec URL: http://homes.drzeus.cx/~drzeus/polypaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/polypaudio/paman-0.9.1-1.src.rpm Description: Polypaudio Manager (paman) is a simple GTK frontend for the Polypaudio sound server. With paman you may browser most of Polypaudio's internals. There is support for changing volume of sinks and sink outputs. You're able to play samples from the sample cache.
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.2-1.src.rpm
MD5Sums: 87dcb41a2c3740eff2e33c094010bb40 paman-0.9.2.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Builds fine in mock. * rpmlint produces no errors. Bad: * MustFix: Desktop file handling does not conform to FE guidelines. Refer to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.3-1.src.rpm
Looks like you missing a BR on desktop-file-utils. Also, is there any reason why your not setting the vendor to fedora?
Ah, right, the BR is missing. For the vendor bit, see the discussion in bug 195223.
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/paman-0.9.3-2.src.rpm BR added.
Ok, this looks good. All blocker issues have been resolved. +1 Approve.
Package Change Request ====================== Package Name: paman Updated Fedora Owners: lpoetter@redhat.com,drzeus-bugzilla@drzeus.cx I am upstream of this package and Pierre agreed to co-maintain this package with me from now on.
CVS done.