Bug 1956365
| Summary: | Review Request: rust-asn1_derive - #[derive] support for asn1 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Heimes <cheimes> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alex.gaynor, decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rust-asn1_derive-0.4.1-1.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-17 03:08:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1956367 | ||
|
Description
Christian Heimes
2021-05-03 14:32:46 UTC
I'll take on this review. Package was generated with rust2rpm, so the review is straightforward: - latest version is packaged - builds and installs on rawhide without errors - license matches upstream specification One issue: The crate does not ship a LICENSE file in the asn1_derive crate. Please report this upstream: https://github.com/alex/rust-asn1 There's already a LICENSE file in the git repo, which is shipped with the "main" crate. Shipping it with the asn1_derive "sub-crate" as well should be as simple as creating a symlink from "asn1_derive/LICENSE" pointing at "../LICENSE". Thanks Fabio, I have filed https://github.com/alex/rust-asn1/issues/130 Great, just add that link as a comment in the .spec file before importing it to Fedora. Most rust crates with similar problems put it in the line below the "# Upstream license specification" comment. I have updated the spec file and added a reference to PR https://github.com/alex/rust-asn1/issues/131 . (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1_derive Build rust-asn1_derive-0.4.1-1.fc35 is now available on Rawhide, https://bodhi.fedoraproject.org/updates/FEDORA-2021-953bd4ab66 Fabio, do we need a backport to F34? (In reply to Christian Heimes from comment #6) > Fabio, do we need a backport to F34? If you expect to need these packages on F34 as well, then yes. If have not already, request the f34 branch in dist-git ("fedpkg request-branch --repo rust-asn1_derive f34"), and then the following should do the trick: "fedpkg switch-branch f34 && git merge rawhide && git push && fedpkg build" You might need a buildroot override for building rust-asn1 afterwards, unless this one will get pushed to stable fast. Or you could use a side tag for f34. FEDORA-2021-8dc9949813 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8dc9949813 FEDORA-2021-8dc9949813 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8dc9949813 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8dc9949813 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-8dc9949813 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |