Bug 1956367 - Review Request: rust-asn1 - ASN.1 (DER) parser and writer for Rust
Summary: Review Request: rust-asn1 - ASN.1 (DER) parser and writer for Rust
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
Depends On: 1956365
TreeView+ depends on / blocked
Reported: 2021-05-03 14:35 UTC by Christian Heimes
Modified: 2021-05-06 21:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed:
Type: ---
decathorpe: fedora-review+

Attachments (Terms of Use)

Description Christian Heimes 2021-05-03 14:35:11 UTC
Spec URL: https://cheimes.fedorapeople.org/rust/rust-asn1.spec
SRPM URL: https://cheimes.fedorapeople.org/rust/rust-asn1-0.4.1-1.fc35.src.rpm
Description: This is a Rust library for parsing and generating ASN.1 data (DER only).
Fedora Account System Username: cheimes

rust-asn1 is a new dependency for next release of PyCA cryptography. The package depends on rust-asn1_derive (rhbz#1956365).

Comment 1 Fabio Valentini 2021-05-06 21:01:51 UTC
Taking on this review.

Comment 2 Fabio Valentini 2021-05-06 21:12:19 UTC
Package is generated with rust2rpm, which simplifies the review:

- package builds and installs without errors on rawhide
- latest version is packaged
- License tag matches license specified by upstream
- conforms to Rust packaging Guidelines

One remaining issue:
The crate source tarball contains a LICENSE file that should be installed with "%license LICENSE" in "%files devel".
Please fix this before importing the package to Fedora.

Package APPROVED (with this minor caveat and FIXME).

Note You need to log in before you can comment on or make changes to this bug.