Bug 1956367

Summary:	Review Request: rust-asn1 - ASN.1 (DER) parser and writer for Rust
Product:	[Fedora] Fedora	Reporter:	Christian Heimes <cheimes>
Component:	Package Review	Assignee:	Christian Heimes <cheimes>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	alex.gaynor, decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-24 12:20:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1956365
Bug Blocks:

Description Christian Heimes 2021-05-03 14:35:11 UTC

Spec URL: https://cheimes.fedorapeople.org/rust/rust-asn1.spec
SRPM URL: https://cheimes.fedorapeople.org/rust/rust-asn1-0.4.1-1.fc35.src.rpm
Description: This is a Rust library for parsing and generating ASN.1 data (DER only).
Fedora Account System Username: cheimes

rust-asn1 is a new dependency for next release of PyCA cryptography. The package depends on rust-asn1_derive (rhbz#1956365).

Comment 1 Fabio Valentini 2021-05-06 21:01:51 UTC

Taking on this review.

Comment 2 Fabio Valentini 2021-05-06 21:12:19 UTC

Package is generated with rust2rpm, which simplifies the review:

- package builds and installs without errors on rawhide
- latest version is packaged
- License tag matches license specified by upstream
- conforms to Rust packaging Guidelines

One remaining issue:
The crate source tarball contains a LICENSE file that should be installed with "%license LICENSE" in "%files devel".
Please fix this before importing the package to Fedora.

Package APPROVED (with this minor caveat and FIXME).

Comment 3 Gwyn Ciesla 2021-05-07 15:46:33 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1

Comment 4 Christian Heimes 2021-05-08 12:23:15 UTC

rust-asn1 fails to build on all platforms except X86_64. I have reported the problem upstream, https://github.com/alex/rust-asn1/issues/132

Comment 5 Package Review 2022-05-24 12:20:38 UTC

Package is available in repositories, closing.