Bug 1958937

Summary:	Allow users to add Sidecar feature gate
Product:	Container Native Virtualization (CNV)	Reporter:	Ruth Netser <rnetser>
Component:	Installation	Assignee:	Nahshon Unna-Tsameret <nunnatsa>
Status:	CLOSED WONTFIX	QA Contact:	Inbar Rose <irose>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.8.0	CC:	cnv-qe-bugs, fdeutsch, stirabos
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-13 11:30:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ruth Netser 2021-05-10 13:00:32 UTC

Description of problem:
Sidecar feature gate was disabled as part of bug 1933070.
Users should have the ability to enable launcher hooks, when needed (this option is currently not available).


Version-Release number of selected component (if applicable):
CNV 4.8.0

How reproducible:


Steps to Reproduce:
1. 
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Simone Tiraboschi 2021-05-11 15:23:40 UTC

Fabian, we explicitly removed the sidecar feature gate considering it a secure hole.
The user can optionally enable it with kubevirt.kubevirt.io/jsonpatch annotation and this will taint the product with a condition like:
 {
   ...
   "message": "Unsupported feature was activated via an HCO annotation",
   "reason": "UnsupportedFeatureAnnotation",
   "status": "True",
   "type": "TaintedConfiguration"
 }

do you think we should consider the sidecar feature gate as a properly supported feature and expose and document an API for it?

Comment 2 Simone Tiraboschi 2021-05-13 11:30:12 UTC

The sidecar feature gate is not something that we want to officially support, it can still be enabled and tested/consumed using the kubevirt.kubevirt.io/jsonpatch annotation on HCO CR.

Closing this as WONTFIX