Bug 1958937 - Allow users to add Sidecar feature gate
Summary: Allow users to add Sidecar feature gate
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Installation
Version: 4.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: 4.8.0
Assignee: Nahshon Unna-Tsameret
QA Contact: Inbar Rose
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-10 13:00 UTC by Ruth Netser
Modified: 2021-05-13 11:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-13 11:30:12 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Ruth Netser 2021-05-10 13:00:32 UTC 
Description of problem:
Sidecar feature gate was disabled as part of bug 1933070.
Users should have the ability to enable launcher hooks, when needed (this option is currently not available).


Version-Release number of selected component (if applicable):
CNV 4.8.0

How reproducible:


Steps to Reproduce:
1. 
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Simone Tiraboschi 2021-05-11 15:23:40 UTC 
Fabian, we explicitly removed the sidecar feature gate considering it a secure hole.
The user can optionally enable it with kubevirt.kubevirt.io/jsonpatch annotation and this will taint the product with a condition like:
 {
   ...
   "message": "Unsupported feature was activated via an HCO annotation",
   "reason": "UnsupportedFeatureAnnotation",
   "status": "True",
   "type": "TaintedConfiguration"
 }

do you think we should consider the sidecar feature gate as a properly supported feature and expose and document an API for it?
Comment 2 Simone Tiraboschi 2021-05-13 11:30:12 UTC 
The sidecar feature gate is not something that we want to officially support, it can still be enabled and tested/consumed using the kubevirt.kubevirt.io/jsonpatch annotation on HCO CR.

Closing this as WONTFIX
Note You need to log in before you can comment on or make changes to this bug.