Bug 1959550

Summary: Overly generic CSS rules for dd and dt elements breaks styling elsewhere in console
Product: OpenShift Container Platform Reporter: Robb Hamilton <rhamilto>
Component: Console Kubevirt PluginAssignee: Aviv Turgeman <aturgema>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: medium Docs Contact:
Priority: high    
Version: 4.8CC: aos-bugs, gouyang
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: non-specific css rules caused styling issues to all dd and dt elements across the application Consequence: non-consistent styling across the application Fix: applying rules to be specific Result: consistent styling across the application
Story Points: ---
Clone Of: Environment:
Version: 4.8.0-0.nightly-2021-05-10-225140 Cluster ID: 9b3a66af-f071-4b37-9fba-8b152858f804 Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36
Last Closed: 2021-07-27 23:08:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1960544    
Attachments:
Description Flags
Pod details page without kubevirt plugin
none
Pod details page with kubevirt plugin installed none

Description Robb Hamilton 2021-05-11 18:34:43 UTC
Created attachment 1782122 [details]
Pod details page without kubevirt plugin

Description of problem:  The rules at https://github.com/openshift/console/blame/master/frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/tabs/review-tab/review-tab.scss#L28-L50 are much too generic in scope and result in layout issues elsewhere in the console when the kubevirt plugin is installed.  These rules need to be scoped to the review tab, ideally with a class on each dd and dt element.


Steps to Reproduce:
1.  With the kubevirt plugin installed, visit a pod details page
2.  Note the space between details dt and dd items is too small

Comment 1 Robb Hamilton 2021-05-11 18:35:14 UTC
Created attachment 1782123 [details]
Pod details page with kubevirt plugin installed

Comment 5 errata-xmlrpc 2021-07-27 23:08:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438