Bug 1959550 - Overly generic CSS rules for dd and dt elements breaks styling elsewhere in console
Summary: Overly generic CSS rules for dd and dt elements breaks styling elsewhere in c...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.8
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 4.8.0
Assignee: Aviv Turgeman
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks: 1960544
TreeView+ depends on / blocked
 
Reported: 2021-05-11 18:34 UTC by Robb Hamilton
Modified: 2021-07-27 23:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: non-specific css rules caused styling issues to all dd and dt elements across the application Consequence: non-consistent styling across the application Fix: applying rules to be specific Result: consistent styling across the application
Clone Of:
Environment:
Version: 4.8.0-0.nightly-2021-05-10-225140 Cluster ID: 9b3a66af-f071-4b37-9fba-8b152858f804 Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36
Last Closed: 2021-07-27 23:08:01 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Pod details page without kubevirt plugin (312.02 KB, image/png)
2021-05-11 18:34 UTC, Robb Hamilton 		no flags Details
Pod details page with kubevirt plugin installed (165.38 KB, image/png)
2021-05-11 18:35 UTC, Robb Hamilton 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8901 0 None open Bug 1959550: Overly generic CSS rules for dd and dt elements breaks styling elsewhere in console 2021-05-12 10:22:25 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:08:18 UTC

Description Robb Hamilton 2021-05-11 18:34:43 UTC 
Created attachment 1782122 [details]
Pod details page without kubevirt plugin

Description of problem:  The rules at https://github.com/openshift/console/blame/master/frontend/packages/kubevirt-plugin/src/components/create-vm-wizard/tabs/review-tab/review-tab.scss#L28-L50 are much too generic in scope and result in layout issues elsewhere in the console when the kubevirt plugin is installed.  These rules need to be scoped to the review tab, ideally with a class on each dd and dt element.


Steps to Reproduce:
1.  With the kubevirt plugin installed, visit a pod details page
2.  Note the space between details dt and dd items is too small
Comment 1 Robb Hamilton 2021-05-11 18:35:14 UTC 
Created attachment 1782123 [details]
Pod details page with kubevirt plugin installed
Comment 5 errata-xmlrpc 2021-07-27 23:08:01 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438
Note You need to log in before you can comment on or make changes to this bug.