Bug 1961025

Summary:	Review Request: golang-github-gorp-3 - Go Relational Persistence - an ORM-ish library for Go
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	golang-github-gorp-3-3.0.2-2.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-04 17:12:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Davide Cavalca 2021-05-17 05:02:34 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp-3.0.2-1.fc35.src.rpm

Description:

Go Relational Persistence - an ORM-ish library for Go.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-05-17 05:02:40 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=68097717

Comment 2 Robert-André Mauchin 🐧 2021-05-21 13:37:32 UTC

 - According to https://github.com/go-gorp/gorp/blob/v3/go.mod

the v3 import path is github.com/go-gorp/gorp/v3

So you should set:

# https://github.com/go-gorp/gorp
%global goipath         github.com/go-gorp/gorp/v3
%global forgeurl        https://github.com/go-gorp/gorp
Version:                3.0.2

So it is properly imported by dependent package.




 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the import path issue before import.

Comment 3 Robert-André Mauchin 🐧 2021-05-21 14:13:13 UTC

/!\ The package and the SPEC filename thus need to be renamed as golang-github-gorp-3/

Comment 4 Davide Cavalca 2021-05-21 15:50:04 UTC

Thanks!

$ fedpkg request-repo golang-github-gorp-3 1961025
https://pagure.io/releng/fedora-scm-requests/issue/34144

Comment 5 Gwyn Ciesla 2021-05-21 16:02:22 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gorp-3