Bug 1961025 - Review Request: golang-github-gorp-3 - Go Relational Persistence - an ORM-ish library for Go
Summary: Review Request: golang-github-gorp-3 - Go Relational Persistence - an ORM-ish...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-17 05:02 UTC by Davide Cavalca
Modified: 2021-08-04 17:12 UTC (History)
2 users (show)

Fixed In Version: golang-github-gorp-3-3.0.2-2.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-04 17:12:24 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Davide Cavalca 2021-05-17 05:02:34 UTC 
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp/golang-github-gorp-3.0.2-1.fc35.src.rpm

Description:

Go Relational Persistence - an ORM-ish library for Go.

Fedora Account System Username: dcavalca
Comment 1 Davide Cavalca 2021-05-17 05:02:40 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=68097717
Comment 2 Robert-André Mauchin 🐧 2021-05-21 13:37:32 UTC 
 - According to https://github.com/go-gorp/gorp/blob/v3/go.mod

the v3 import path is github.com/go-gorp/gorp/v3

So you should set:

# https://github.com/go-gorp/gorp
%global goipath         github.com/go-gorp/gorp/v3
%global forgeurl        https://github.com/go-gorp/gorp
Version:                3.0.2

So it is properly imported by dependent package.




 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the import path issue before import.
Comment 3 Robert-André Mauchin 🐧 2021-05-21 14:13:13 UTC 
/!\ The package and the SPEC filename thus need to be renamed as golang-github-gorp-3/
Comment 4 Davide Cavalca 2021-05-21 15:50:04 UTC 
Thanks!

$ fedpkg request-repo golang-github-gorp-3 1961025
https://pagure.io/releng/fedora-scm-requests/issue/34144
Comment 5 Gwyn Ciesla 2021-05-21 16:02:22 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gorp-3
Note You need to log in before you can comment on or make changes to this bug.