Bug 1962641

Summary:	Add "Count threads as cores" to Grafana dashboards
Product:	[oVirt] ovirt-engine-dwh	Reporter:	Aviv Litman <alitman>
Component:	Grafana	Assignee:	Aviv Litman <alitman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Novotny <pnovotny>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4.4	CC:	dfodor, mperina, sradco
Target Milestone:	ovirt-4.4.7	Flags:	pm-rhel: ovirt-4.4+
Target Release:	4.4.7.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-dwh-4.4.7.2	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-28 14:16:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1896359
Bug Blocks:

Description Aviv Litman 2021-05-20 12:45:59 UTC

Description of problem:
The calculation for the hosts cpu number in Grafana dashboards is always 'number_of_cores' no matter what the value of the 'count_threads_as_cores' column.

Version-Release number of selected component (if applicable):
4.4.6.3

How reproducible:
100%

Steps to Reproduce:
1.Go to Grafana dashboards that show the hosts cpu cores
2. see that the queries use only the 'number_of_cores' column

Relevant dashboards:
1. Host Dashboard
2. Cluster Dashboard
3. Hosts Inventory Dashboard
4. Inventory Dashboard
5. Hosts Uptime Dashboard
6. Hosts Trend Dashboard
 

Actual results:
The calculation for the hosts cpu number is always 'number_of_cores' no matter what the value of the 'count_threads_as_cores' column.

Expected results:
The queries that use the 'number_of_cores' column from the hosts tables will consider the value in the 'count_threads_as_cores' column.

If 'Count threads as cores' value is true: the calculation for the hosts cpu number will be:
number_of_threads

If it is false or null the calculation will be: 
number_of_cores

Comment 2 Pavel Novotny 2021-07-09 23:33:43 UTC

Verified in 
ovirt-engine-4.4.7.6-0.11.el8ev.noarch
ovirt-engine-dwh-4.4.7.3-1.el8ev.noarch

The 'Count Threads As Cores' value is now taken into account when displaying the Num of CPUs in the dashboards described in comment 0:
1. Host Dashboard
2. Cluster Dashboard
3. Hosts Inventory Dashboard
4. Inventory Dashboard
5. Hosts Uptime Dashboard
6. Hosts Trend Dashboard

For example host(s) with: 
Thread(s) per core:  2
Core(s) per socket:  8
Socket(s):           2

report 16 CPUs in the dashborads when 'Count Threads As Cores' is set to False
and 32 CPUs when 'Count Threads As Cores' is True.

Comment 3 Sandro Bonazzola 2021-07-28 14:16:44 UTC

This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.