Bug 1962641 - Add "Count threads as cores" to Grafana dashboards
Summary: Add "Count threads as cores" to Grafana dashboards
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Grafana
Version: 4.4.4
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.4.7
: 4.4.7.2
Assignee: Aviv Litman
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On: 1896359
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-20 12:45 UTC by Aviv Litman
Modified: 2021-07-28 14:16 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-dwh-4.4.7.2
Clone Of:
Environment:
Last Closed: 2021-07-28 14:16:44 UTC
oVirt Team: Metrics
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 115281 0 master MERGED Add "Count threads as cores" to Grafana dashboards 2021-06-22 11:59:45 UTC

Description Aviv Litman 2021-05-20 12:45:59 UTC
Description of problem:
The calculation for the hosts cpu number in Grafana dashboards is always 'number_of_cores' no matter what the value of the 'count_threads_as_cores' column.

Version-Release number of selected component (if applicable):
4.4.6.3

How reproducible:
100%

Steps to Reproduce:
1.Go to Grafana dashboards that show the hosts cpu cores
2. see that the queries use only the 'number_of_cores' column

Relevant dashboards:
1. Host Dashboard
2. Cluster Dashboard
3. Hosts Inventory Dashboard
4. Inventory Dashboard
5. Hosts Uptime Dashboard
6. Hosts Trend Dashboard
 

Actual results:
The calculation for the hosts cpu number is always 'number_of_cores' no matter what the value of the 'count_threads_as_cores' column.

Expected results:
The queries that use the 'number_of_cores' column from the hosts tables will consider the value in the 'count_threads_as_cores' column.

If 'Count threads as cores' value is true: the calculation for the hosts cpu number will be:
number_of_threads

If it is false or null the calculation will be: 
number_of_cores

Comment 2 Pavel Novotny 2021-07-09 23:33:43 UTC
Verified in 
ovirt-engine-4.4.7.6-0.11.el8ev.noarch
ovirt-engine-dwh-4.4.7.3-1.el8ev.noarch

The 'Count Threads As Cores' value is now taken into account when displaying the Num of CPUs in the dashboards described in comment 0:
1. Host Dashboard
2. Cluster Dashboard
3. Hosts Inventory Dashboard
4. Inventory Dashboard
5. Hosts Uptime Dashboard
6. Hosts Trend Dashboard

For example host(s) with: 
Thread(s) per core:  2
Core(s) per socket:  8
Socket(s):           2

report 16 CPUs in the dashborads when 'Count Threads As Cores' is set to False
and 32 CPUs when 'Count Threads As Cores' is True.

Comment 3 Sandro Bonazzola 2021-07-28 14:16:44 UTC
This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.