Bug 1963409
| Summary: | Review Request: golang-gopkg-gorp-1 - Go Relational Persistence - an ORM-ish library for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | golang-gopkg-gorp-1-1.7.2-1.fc35 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-04 17:32:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1963410 | ||
|
Description
Davide Cavalca
2021-05-23 03:34:36 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=68510354 If you check the README, at https://github.com/go-gorp/gorp/tree/v1#installation it says the valid import path is gopkg.in/gorp.v1 So you need to state that as the main import path: # https://github.com/go-gorp/gorp %global goipath gopkg.in/gorp.v1 %global forgeurl https://github.com/go-gorp/gorp Version: 1.7.2 See in your dependent package golang-github-rubenv-sql-migrate, it imports: BuildRequires: golang(gopkg.in/gorp.v1) You can also switch the alternative import path too:. %global goaltipaths github.com/go-gorp/gorp In any case you'll need to fix; the SPEC filename and this bug name to match the value computed in %goname (golang-gopkg-gorp-1). - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Thanks! I've fixed the import path and reuploaded with the correct name. Spec URL: https://dcavalca.fedorapeople.org/review/golang-gopkg-gorp-1/golang-gopkg-gorp-1.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-gopkg-gorp-1/golang-gopkg-gorp-1-1.7.2-1.fc35.src.rpm Let me know if I should fix anything else to move this forward. Thanks! Ooop aorry I missed the mail for this. Package approved. Thanks! $ fedpkg request-repo golang-gopkg-gorp-1 1963409 https://pagure.io/releng/fedora-scm-requests/issue/34569 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-gorp-1 |