Bug 1963409 - Review Request: golang-gopkg-gorp-1 - Go Relational Persistence - an ORM-ish library for Go
Summary: Review Request: golang-gopkg-gorp-1 - Go Relational Persistence - an ORM-ish ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1963410
TreeView+ depends on / blocked
 
Reported: 2021-05-23 03:34 UTC by Davide Cavalca
Modified: 2021-08-04 17:32 UTC (History)
2 users (show)

Fixed In Version: golang-gopkg-gorp-1-1.7.2-1.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-08-04 17:32:12 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-05-23 03:34:36 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp-1/golang-github-gorp-1.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-gorp-1/golang-github-gorp-1-1.7.2-1.fc35.src.rpm

Description:

Go Relational Persistence - an ORM-ish library for Go.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-05-23 03:35:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=68510354

Comment 2 Robert-André Mauchin 🐧 2021-05-28 15:05:01 UTC
If you check the README, at https://github.com/go-gorp/gorp/tree/v1#installation
it says the valid import path is gopkg.in/gorp.v1
So you need to state that as the main import path:

# https://github.com/go-gorp/gorp
%global goipath         gopkg.in/gorp.v1
%global forgeurl        https://github.com/go-gorp/gorp
Version:                1.7.2


See in your dependent package golang-github-rubenv-sql-migrate, it imports:

BuildRequires:  golang(gopkg.in/gorp.v1) 

You can also switch the alternative import path too:.

%global goaltipaths github.com/go-gorp/gorp

In any case you'll need to fix; the SPEC filename and this bug name to match the value computed in %goname (golang-gopkg-gorp-1).


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 3 Davide Cavalca 2021-05-28 16:42:42 UTC
Thanks! I've fixed the import path and reuploaded with the correct name.

Spec URL: https://dcavalca.fedorapeople.org/review/golang-gopkg-gorp-1/golang-gopkg-gorp-1.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-gopkg-gorp-1/golang-gopkg-gorp-1-1.7.2-1.fc35.src.rpm

Comment 4 Davide Cavalca 2021-06-04 14:55:37 UTC
Let me know if I should fix anything else to move this forward. Thanks!

Comment 5 Robert-André Mauchin 🐧 2021-06-11 05:41:22 UTC
Ooop aorry I missed the mail for this.

Package approved.

Comment 6 Davide Cavalca 2021-06-11 15:46:46 UTC
Thanks!

$ fedpkg request-repo golang-gopkg-gorp-1 1963409
https://pagure.io/releng/fedora-scm-requests/issue/34569

Comment 7 Gwyn Ciesla 2021-06-11 16:16:40 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-gorp-1


Note You need to log in before you can comment on or make changes to this bug.