Bug 1964694
| Summary: | Review Request: rust-femme - Pretty-printer and ndjson logger for log crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | o.lemasle, package-review |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-06-04 01:12:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2021-05-25 21:01:02 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=68735460 As the two PNG files (pretty.png and ndjson.png) are referenced in README.md, shouldn't they be in %doc too? Files list: /usr/share/cargo/registry/femme-2.1.1/.cargo-checksum.json /usr/share/cargo/registry/femme-2.1.1/Cargo.toml /usr/share/cargo/registry/femme-2.1.1/LICENSE-APACHE /usr/share/cargo/registry/femme-2.1.1/LICENSE-MIT /usr/share/cargo/registry/femme-2.1.1/README.md /usr/share/cargo/registry/femme-2.1.1/examples/log.rs /usr/share/cargo/registry/femme-2.1.1/examples/million.rs /usr/share/cargo/registry/femme-2.1.1/ndjson.png <----- /usr/share/cargo/registry/femme-2.1.1/pretty.png <----- /usr/share/cargo/registry/femme-2.1.1/src/lib.rs /usr/share/cargo/registry/femme-2.1.1/src/ndjson.rs /usr/share/cargo/registry/femme-2.1.1/src/pretty.rs /usr/share/cargo/registry/femme-2.1.1/src/wasm.rs /usr/share/doc/rust-femme-devel/README.md /usr/share/licenses/rust-femme-devel/LICENSE-APACHE /usr/share/licenses/rust-femme-devel/LICENSE-MIT Hm. Not sure they add any value, since I guess nobody would look at /usr/share/doc/rust-femme-devel/README.md with an editor that supports HTML preview for markdown files ... and if anybody wants to, these files *and* the README are still included in the crate sources directly. Ok. - Licenses OK - Conforms to packaging guidelines - builds in mock - no rpmlint error - latest version packaged Package approved Thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/34258 https://pagure.io/releng/fedora-scm-requests/issue/34259 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-femme FEDORA-2021-e9ef597214 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214 FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e9ef597214 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |