Bug 1964694 - Review Request: rust-femme - Pretty-printer and ndjson logger for log crate
Summary: Review Request: rust-femme - Pretty-printer and ndjson logger for log crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-25 21:01 UTC by Fabio Valentini
Modified: 2021-06-04 01:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-04 01:12:56 UTC
Type: ---
Embargoed:
o.lemasle: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2021-05-25 21:01:02 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-femme.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-femme-2.1.1-1.fc34.src.rpm

Description:
Not just a pretty (inter)face: pretty-printer and ndjson logger for log crate.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-05-25 21:01:06 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=68735460

Comment 2 Olivier Lemasle 2021-05-26 19:58:39 UTC
As the two PNG files (pretty.png and ndjson.png) are referenced in README.md, shouldn't they be in %doc too?

Files list:

/usr/share/cargo/registry/femme-2.1.1/.cargo-checksum.json
/usr/share/cargo/registry/femme-2.1.1/Cargo.toml
/usr/share/cargo/registry/femme-2.1.1/LICENSE-APACHE
/usr/share/cargo/registry/femme-2.1.1/LICENSE-MIT
/usr/share/cargo/registry/femme-2.1.1/README.md
/usr/share/cargo/registry/femme-2.1.1/examples/log.rs
/usr/share/cargo/registry/femme-2.1.1/examples/million.rs
/usr/share/cargo/registry/femme-2.1.1/ndjson.png               <-----
/usr/share/cargo/registry/femme-2.1.1/pretty.png               <-----
/usr/share/cargo/registry/femme-2.1.1/src/lib.rs
/usr/share/cargo/registry/femme-2.1.1/src/ndjson.rs
/usr/share/cargo/registry/femme-2.1.1/src/pretty.rs
/usr/share/cargo/registry/femme-2.1.1/src/wasm.rs
/usr/share/doc/rust-femme-devel/README.md
/usr/share/licenses/rust-femme-devel/LICENSE-APACHE
/usr/share/licenses/rust-femme-devel/LICENSE-MIT

Comment 3 Fabio Valentini 2021-05-26 20:30:39 UTC
Hm. Not sure they add any value, since I guess nobody would look at /usr/share/doc/rust-femme-devel/README.md with an editor that supports HTML preview for markdown files ... and if anybody wants to, these files *and* the README are still included in the crate sources directly.

Comment 4 Olivier Lemasle 2021-05-26 21:13:13 UTC
Ok.

- Licenses OK
- Conforms to packaging guidelines
- builds in mock
- no rpmlint error
- latest version packaged

Package approved

Comment 6 Gwyn Ciesla 2021-05-26 21:33:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-femme

Comment 7 Fedora Update System 2021-05-26 22:37:13 UTC
FEDORA-2021-e9ef597214 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214

Comment 8 Fedora Update System 2021-05-27 01:32:53 UTC
FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e9ef597214 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e9ef597214

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-06-04 01:12:56 UTC
FEDORA-2021-e9ef597214 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.