Bug 1964954

Summary:	Block VM with 'evictionStrategy: LiveMigrate' from running in the cases: GPU only
Product:	Container Native Virtualization (CNV)	Reporter:	Kedar Bidarkar <kbidarka>
Component:	Virtualization	Assignee:	Jed Lejosne <jlejosne>
Status:	CLOSED NOTABUG	QA Contact:	Israel Pinto <ipinto>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.4.0	CC:	cnv-qe-bugs, jlejosne, kbidarka, rnetser, sgott
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1858777	Environment:
Last Closed:	2021-07-09 18:15:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kedar Bidarkar 2021-05-26 12:23:56 UTC

+++ This bug was initially created as a clone of Bug #1858777 +++

Description of problem:
If a VM is using local PV and its evictionStrategy: LiveMigrate, OCP upgrade would result with nodes in "Ready,SchedulingDisable" state.
As a VM with local PVs and evictionStrategy: LiveMigrate is not a supported use case at the moment, such VMs should be blocked from running.


Version-Release number of selected component (if applicable):
CNV 2.4

--- Additional comment from Israel Pinto on 2020-07-21 12:01:09 UTC ---

Doc BZ for 2.4: https://bugzilla.redhat.com/show_bug.cgi?id=1859129

--- Additional comment from Ruth Netser on 2020-08-02 08:35:00 UTC ---

The same block logic should also be applied to VMs with pass-through features such as SRIOV and GPU

--- Additional comment from Jed Lejosne on 2020-08-05 15:42:24 UTC ---

I addressed both SRIOV and GPUs there: https://github.com/kubevirt/kubevirt/pull/3944
Local PVs is more complicated, since we don't know at VMI creation if PVs are local or not.

--- Additional comment from Kedar Bidarkar on 2020-08-19 12:28:39 UTC ---

Further design work needs to be done for this bug and so we plan to move it to future for now.

--- Additional comment from Kedar Bidarkar on 2020-11-18 13:14:56 UTC ---

@sgott split this bug into two:
a) One to address both SRIOV and GPUs related stuff and 
b) Another for the Local PV

Comment 3 sgott 2021-07-01 20:37:05 UTC

Per comments in the PR created to address this: https://github.com/kubevirt/kubevirt/pull/3944 it's clear that the premise behind this BZ isn't correct. It is possible to migrate VMs that require specialized hardware, e.g. GPU--as long as the destination has compatible hardware.

Kedar, I think we should close this BZ as NOTABUG. What do you think?

Comment 4 sgott 2021-07-09 18:15:14 UTC

Closing this PR as per Comment #3: We believe the current behavior is correct. Please feel free to re-open if you think this isn't the correct action.

Comment 5 Red Hat Bugzilla 2023-09-15 01:07:13 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days