Bug 1966792

Summary: Drop unnecessary findbugs dependency from ongres-scram
Product: [Fedora] Fedora Reporter: Richard Fearn <richardfearn>
Component: ongres-scramAssignee: Augusto Caringi <acaringi>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: acaringi, jjanco, odubaj, praiskup
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-09 07:30:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1964634    

Description Richard Fearn 2021-06-01 21:19:46 UTC
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

ongres-scram currently has this dependency:

  BuildRequires:  findbugs

This is due to this dependency in the ongres-scram POM:

        <dependency>
            <groupId>com.google.code.findbugs</groupId>
            <artifactId>annotations</artifactId>
            <version>3.0.1</version>
            <scope>provided</scope>
        </dependency>

That dependency can be downloaded here:

  https://search.maven.org/artifact/com.google.code.findbugs/annotations/3.0.1/jar

It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". Searching the ongres-scram source for "annotation", I can only see one usage of the SuppressFBWarnings annotation, in com.ongres.scram.common.message.ServerFinalMessage.

Removing the use of this annotation would allow ongres-scram to build without FindBugs.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/

Comment 2 Pavel Raiskup 2021-06-09 07:30:36 UTC
THanks Richard, here is the build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69676565

Comment 3 Richard Fearn 2021-06-09 11:13:53 UTC
Thanks Pavel!