Bug 1968336

Summary: [master] missing role in agent CRD
Product: OpenShift Container Platform Reporter: Eran Cohen <ercohen>
Component: assisted-installerAssignee: Fred Rolland <frolland>
assisted-installer sub component: assisted-service QA Contact: Yuri Obshansky <yobshans>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: aos-bugs, atraeger, frolland, mfilanov, nshidlin
Version: 4.8Keywords: Triaged
Target Milestone: ---Flags: frolland: needinfo-
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AI-Team-Hive KNI-EDGE-JUKE-4.8
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1970269 (view as bug list) Environment:
Last Closed: 2021-10-18 17:32:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1970269    

Description Eran Cohen 2021-06-07 07:37:17 UTC 
Description of problem:

It's impossible to know what is the host role (master or worker) when installing a multi-node cluster with the operator.

I think it's also required to set the bootstrap flag on the agent CR as well

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Install a multi-node cluster 
2.
3.

Actual results:
Try to figure out the role of each host

Expected results:
See have a hostRole field on the agent 
See if the host is the bootstrap node

Additional info:
Comment 1 Fred Rolland 2021-06-07 09:05:11 UTC 
@mfilanov FYI
Comment 2 Michael Filanov 2021-06-07 09:09:34 UTC 
Originally auto assigned role should not be supported in kube-api but we cannot require it on creation because
Comment 3 Michael Filanov 2021-06-07 09:14:02 UTC 
Originally auto assigned role should not be supported in kube-api but we cannot require it on creation because the CR is created automatically. 
User can set the role in two ways, bmac annotations, edit the spec of the agent. 
possible solution is to add the role to the status then even auto-assign will be selected once the installation is starting. 
Another way is to add a condition in the agent, but then cluster deployment controller will need to validate those conditions before starting the installation. 

@atraeger what do you think? 


Bootstrap can be added to the status (probably should be a different ticket)
Comment 4 Fred Rolland 2021-06-10 08:03:27 UTC 
Also HostNTPSources should be added.
Comment 8 errata-xmlrpc 2021-10-18 17:32:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759