Bug 1970269 - [4.8.0] missing role in agent CRD
Summary: [4.8.0] missing role in agent CRD
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: assisted-installer
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.8.0
Assignee: Fred Rolland
QA Contact: Yuri Obshansky
URL:
Whiteboard: AI-Team-Hive KNI-EDGE-JUKE-4.8
Depends On: 1968336
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-10 08:06 UTC by Michael Filanov
Modified: 2021-07-27 23:12 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of: 1968336
Environment:
Last Closed: 2021-07-27 23:12:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift assisted-service pull 2016 0 None open [ocm-2.3] Bug 1970269: Add role, bootstrap and ntp sources to Agent CR 2021-06-20 11:23:59 UTC
Red Hat Bugzilla 1968336 1 medium CLOSED [master] missing role in agent CRD 2021-10-18 17:33:12 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:12:42 UTC

Description Michael Filanov 2021-06-10 08:06:13 UTC
+++ This bug was initially created as a clone of Bug #1968336 +++

Description of problem:

It's impossible to know what is the host role (master or worker) when installing a multi-node cluster with the operator.

I think it's also required to set the bootstrap flag on the agent CR as well

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Install a multi-node cluster 
2.
3.

Actual results:
Try to figure out the role of each host

Expected results:
See have a hostRole field on the agent 
See if the host is the bootstrap node

Additional info:

--- Additional comment from frolland on 20210607T09:05:11

@mfilanov FYI

--- Additional comment from mfilanov on 20210607T09:09:34

Originally auto assigned role should not be supported in kube-api but we cannot require it on creation because

--- Additional comment from mfilanov on 20210607T09:14:02


Originally auto assigned role should not be supported in kube-api but we cannot require it on creation because the CR is created automatically. 
User can set the role in two ways, bmac annotations, edit the spec of the agent. 
possible solution is to add the role to the status then even auto-assign will be selected once the installation is starting. 
Another way is to add a condition in the agent, but then cluster deployment controller will need to validate those conditions before starting the installation. 

@atraeger what do you think? 


Bootstrap can be added to the status (probably should be a different ticket)

--- Additional comment from frolland on 20210610T08:03:27

Also HostNTPSources should be added.

Comment 3 Trey West 2021-06-30 13:53:40 UTC
Verified on 2.3.0-DOWNSTREAM-2021-06-29-05-03-27

Comment 5 errata-xmlrpc 2021-07-27 23:12:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.