Bug 1968570

Summary:	[master] Misleading error when ClusterImageSet specifies OpenShift version lower than 4.8
Product:	OpenShift Container Platform	Reporter:	Mat Kowalski <mko>
Component:	assisted-installer	Assignee:	Rom Freiman <rfreiman>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aos-bugs, bjacot, mfilanov, mhrivnak
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	KNI-EDGE-JUKE-4.8 AI-Team-Hive
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1972532 (view as bug list)		Environment:
Last Closed:	2021-10-18 17:32:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1972532, 1972533

Description Mat Kowalski 2021-06-07 15:08:19 UTC

+++ Description of problem:

The error message returned to the operator when trying to create installation with OpenShift version lower than 4.8 is slightly misleading

+++ Steps to Reproduce:

1. Create ClusterImageSet "openshift-v4.7.14" pointing to "quay.io/openshift-release-dev/ocp-release:4.7.14-x86_64"
2. Create AgentClusterInstall with imageSetRef "openshift-v4.7.14"
3. Create ClusterDeployment
4. Create InfraEnv

+++ Actual results:

ACI shows error "BackendError" with reason "The Spec could not be synced due to backend error: OCP version is not specified in OPENSHIFT_VERSIONS: 4.7"

IE shows error "ImageCreationError" with reason "Failed to create image: record not found"

+++ Expected results:

As an operator it's not completely clear to me that "OCP version is not specified [...]" is equivalent to the check being performed here (i.e. whether it's at least version 4.8

Comment 1 Michael Hrivnak 2021-06-07 15:17:32 UTC

A k8s API message should not mention specific environment variables. Here, a more clear message would be something like "RHCOS image is not configured for version 4.7". A hint about where to go to configure it would be a bonus.

Comment 2 Michael Filanov 2021-06-22 08:26:10 UTC

*** Bug 1968427 has been marked as a duplicate of this bug. ***

Comment 3 Michael Filanov 2021-06-22 08:26:29 UTC

*** Bug 1972533 has been marked as a duplicate of this bug. ***

Comment 4 Raz Regev 2021-06-25 16:35:19 UTC

fixed in commit 312a96085bae4b5cfebf1f0bd5d9e2575ad5269f

Comment 9 errata-xmlrpc 2021-10-18 17:32:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759