Bug 1969470

Summary: [4.8.0] Misleading error in case of install-config override bad input
Product: OpenShift Container Platform Reporter: Michael Filanov <mfilanov>
Component: assisted-installerAssignee: Daniel Erez <derez>
assisted-installer sub component: Deployment Operator QA Contact: bjacot
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: aos-bugs, itsoiref, mfilanov
Version: 4.8Keywords: Triaged
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: KNI-EDGE-JUKE-4.8 AI-Team-Hive
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1968406 Environment:
Last Closed: 2021-07-27 23:12:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1968406    
Bug Blocks:    

Description Michael Filanov 2021-06-08 13:39:39 UTC 
+++ This bug was initially created as a clone of Bug #1968406 +++

Description of problem:
In case we set bad json in install config override, error is not accurate enough.

message: 'The Spec could not be synced due to an input error: invalid character
      ''{'' looking for beginning of object key string'

It should explain that error is in install-config annotation 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from alazar on 20210607T12:41:00

*** Bug 1968405 has been marked as a duplicate of this bug. ***

--- Additional comment from mfilanov on 20210608T13:35:22

we call a specific api to update the install config so in this case we can probably wrap the error and reply a more detailed error for the user, for example if the error is 4xx then we will wrap it. 
Need to check how to handle updateState without breaking the internal logic that check the error type. maybe add optional wrap message to the function.
Comment 6 errata-xmlrpc 2021-07-27 23:12:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438