Bug 1969470 - [4.8.0] Misleading error in case of install-config override bad input
Summary: [4.8.0] Misleading error in case of install-config override bad input
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: assisted-installer
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.8.0
Assignee: Daniel Erez
QA Contact: bjacot
URL:
Whiteboard: KNI-EDGE-JUKE-4.8 AI-Team-Hive
Depends On: 1968406
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-08 13:39 UTC by Michael Filanov
Modified: 2021-07-27 23:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1968406
Environment:
Last Closed: 2021-07-27 23:12:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift assisted-service pull 2058 0 None open Bug 1969470: parsing error indication for config override 2021-06-23 11:43:44 UTC
Red Hat Bugzilla 1968406 1 medium CLOSED [master] Misleading error in case of install-config override bad input 2021-10-18 17:33:23 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:12:17 UTC

Description Michael Filanov 2021-06-08 13:39:39 UTC
+++ This bug was initially created as a clone of Bug #1968406 +++

Description of problem:
In case we set bad json in install config override, error is not accurate enough.

message: 'The Spec could not be synced due to an input error: invalid character
      ''{'' looking for beginning of object key string'

It should explain that error is in install-config annotation 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from alazar on 20210607T12:41:00

*** Bug 1968405 has been marked as a duplicate of this bug. ***

--- Additional comment from mfilanov on 20210608T13:35:22

we call a specific api to update the install config so in this case we can probably wrap the error and reply a more detailed error for the user, for example if the error is 4xx then we will wrap it. 
Need to check how to handle updateState without breaking the internal logic that check the error type. maybe add optional wrap message to the function.

Comment 6 errata-xmlrpc 2021-07-27 23:12:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.